generator-node icon indicating copy to clipboard operation
generator-node copied to clipboard

downgrading husky 2.6.0 and add eslintrc.js

Open bung87 opened this issue 4 years ago • 4 comments

https://github.com/typicode/husky/blob/master/src/installer/gitRevParse.ts#L9 https://github.com/typicode/husky/issues/580

add eslintrc.js so the brand new package can pass npm run test

bung87 avatar Feb 15 '20 07:02 bung87

Can you explain what Husky 3.x is breaking on your side? It's unclear to me what's the issue from the issue you linked. Husky 3 has been working fine where I've used it.

SBoudrias avatar Feb 16 '20 16:02 SBoudrias

when generating new project , during post install husky ,when Setting up git hooks it will throw error , I'v tried multiple times.

bung87 avatar Feb 16 '20 16:02 bung87

you should create pull request per each feature.

  • husky change: questionable
  • eslint: probably would had been already merged if it wasn't combined with husky

glensc avatar Mar 22 '22 07:03 glensc

also, https://github.com/typicode/husky/issues/580 is closed by now

glensc avatar Mar 22 '22 07:03 glensc