generator-angular icon indicating copy to clipboard operation
generator-angular copied to clipboard

add more complete Less support

Open ghatchue opened this issue 9 years ago • 4 comments

This patch adds Less support; it is based on the patch from @lexaficus, with some bug fixes added. The other pull request is currently on hold due to a merge issue, so I decided to create an new one for these changes. This patch adds the following features/fixes that were not in the original patch:

  • When using Less, there is a prompt to let users decide whether to use the Less version of Bootstrap, or the regular CSS version
  • Bootstrap stylesheets were included twice in the original patch. In the Less stylesheet via (@import .../bootstrap.less), and also in index.html via the wiredep plugin (bower:css). This is fixed with this patch.
  • Wiredep is also better integrated with Less in this patch. I added a bower:less in the generated Less stylesheet.
  • Other cleanup in _Gruntfile.js (e.g. The copy:styles task is not generated when using Sass or Less, fonts files are assembled in the default bootstrap folders: /fonts/ when using the Less version of Bootstrap, /fonts/bootstrap/ when using the Sass version of bootstrap; Having font files in /dist/bower_components/... is very out of place in a distribution folder.)

ghatchue avatar Dec 26 '14 22:12 ghatchue

I personally don't like more options, honestly. @eddiemonge WDYT?

arthurvr avatar Jun 30 '15 07:06 arthurvr

my goal was to rewrite so people could compose it and add their own things like this but I ran out of time. I may revisit that idea soon though

eddiemonge avatar Jun 30 '15 18:06 eddiemonge

If you resolve the conflicts and update the commit message to follow the contributing guideline I'll land this pr

eddiemonge avatar Jul 24 '15 18:07 eddiemonge

This feature would be what I need, great work @ghatchue!

harm-less avatar Aug 05 '15 07:08 harm-less