generator-angular
generator-angular copied to clipboard
feat(gen) add grunt-ngdoc to Gruntfile
Grunt part of the pull request #551
How much test coverage should be have here?
these two lines should be modified: https://github.com/marcin-wosinek/generator-angular/blob/ngdocs-grunt/templates/common/root/_Gruntfile.js#L77-L78
In the lines you've mentioned I've added watching for changes in documentation.
I meant this line will livereload and put files in .tmp: https://github.com/yeoman/generator-angular/pull/680/files#diff-c90fa6beac4c4a4ca179fcb210e6e096R43 which will then trigger the livereload on line https://github.com/yeoman/generator-angular/pull/680/files#diff-c90fa6beac4c4a4ca179fcb210e6e096R78 which can result in excessive livereloads. So if coffee dont listen for that second line anymore
Ok, I got it now.
In neither cases we don't need to watch docs files. this will live reload docs for coffee; and this in case of js.
I've tests and in both cases doc page is automatically refreshed when doc is regenerated.
No, not for the docs. Im talking about normal JS. When a .coffee file is edited, it does not trigger a live reload. CS writing the processed files to the .tmp folder trigger the live reload.
With your change, a live reload is also triggered when the docs are updated. Line 78 of your changes should be removed since line 46 will do the same.
updated
im not a fan of having the docs in the actual site
Ideally these should be available on a different "site". As in not part of the actual site the user is building since end users of the developers project don't/shouldn't need to see the docs for the code part.