generator-angular icon indicating copy to clipboard operation
generator-angular copied to clipboard

htmlmin settings incomplete

Open JoernBerkefeld opened this issue 8 years ago • 1 comments

it currently reads as follows for the htmlmin task:

    options: {
      collapseWhitespace: true,
      conservativeCollapse: true,
      collapseBooleanAttributes: true,
      removeCommentsFromCDATA: true
    }

that's quite insufficient because inline JS and CSS will stay as is, so will html comments. Instead the options should be set to:

    options: {
      removeComments: true, // **new**
      minifyJS: true, // **new**
      minifyCSS: true, // **new**
      collapseWhitespace: true,
      conservativeCollapse: true,
      collapseBooleanAttributes: true,
      removeCommentsFromCDATA: true
    }

JoernBerkefeld avatar Apr 07 '16 13:04 JoernBerkefeld

HTML comments might be essential, especially if people are using that for angular (eww though). The other options are interesting

eddiemonge avatar Apr 11 '16 18:04 eddiemonge