generator-angular icon indicating copy to clipboard operation
generator-angular copied to clipboard

fix(gulpfile): gulp bower not wiring deps correctly

Open alfonso-presa opened this issue 8 years ago • 11 comments

This solved the problem reported in #1199 for me.

Closes #1199

alfonso-presa avatar Jan 11 '16 10:01 alfonso-presa

Hi, when it will be merged? Bug #1199 still reproducable

agalitsyn avatar Feb 05 '16 07:02 agalitsyn

No idea.... Owners/Colabs, any feedback?

alfonso-presa avatar Feb 05 '16 08:02 alfonso-presa

I've had to rebase this due to conflicts... Anything I can do to help speed this PR's merge?

Thanks!

alfonso-presa avatar Mar 01 '16 21:03 alfonso-presa

It fixed, thanks! I've to download this patch and apply it manually.

For created project:

cd /path/to/created/project/
curl -LO https://github.com/yeoman/generator-angular/pull/1247.patch
patch -b gulpfile.js 1247.patch

For generator-angular:

cd /usr/local/lib/node_modules/generator-angular
curl -LO https://github.com/yeoman/generator-angular/pull/1247.patch
patch -b -p1 < 1247.patch

mnloop avatar Apr 22 '16 15:04 mnloop

The test/karma.conf.js file also need to be updated.

mnloop avatar Apr 22 '16 16:04 mnloop

One thing that would be nice is if the bower task could be added into task chain of tasks such as default or serve. Currently, the bower task appears to only run if bower.json is changed.

ghost avatar Aug 20 '16 15:08 ghost

+1 to @LonnyGomes' comment.

bretmattingly avatar Sep 08 '16 14:09 bretmattingly

Why has this not been merged yet? The issue still persists and this fixes it.

MatissJanis avatar Nov 29 '16 16:11 MatissJanis

yup, issue still there and this worked for me.

gscottqueen avatar Jan 20 '17 18:01 gscottqueen

Merge please

jfrumar avatar Feb 04 '17 20:02 jfrumar

Is this ever going to be merged? Should I drop the PR?

alfonso-presa avatar Mar 21 '18 07:03 alfonso-presa