environment icon indicating copy to clipboard operation
environment copied to clipboard

outdated types in @types/yeoman-environment

Open a-b-r-o-w-n opened this issue 3 years ago • 10 comments

The latest release of the @types/yeoman-environment package is 2.10.2

I know the major was just bumped a week ago, but any chance we can get the typings updated soon?

a-b-r-o-w-n avatar Mar 12 '21 20:03 a-b-r-o-w-n

This issue is stale because it has been open with no activity. Remove stale label or comment or this will be closed

github-actions[bot] avatar Apr 13 '21 00:04 github-actions[bot]

Commenting to remove stale label. This is still needed.

a-b-r-o-w-n avatar Apr 15 '21 16:04 a-b-r-o-w-n

@a-b-r-o-w-n is there something specific missing in @types/yeoman-environment?

manuth avatar May 22 '21 15:05 manuth

It looks like Environment.run is still listed as taking a callback parameter in @types/[email protected], but it was changed to an async method in [email protected] such that the TypeScript compiler complains when awaiting the result of .run.

cgranade avatar Jun 23 '21 16:06 cgranade

Hi, this still hasn't been resolved.

Is anyone actively working on this?

tdashworth avatar Oct 18 '21 15:10 tdashworth

Yes I'm running into this as well. I thought I was overlooking something.

GerbenRampaart avatar Nov 12 '21 14:11 GerbenRampaart

I'm not even sure which version it's based on, maybe v2.x.x.

If I get the time, I'll try to contribute back some updated types although the docs site isn't terribly informative, especially around the TerminalAdapter - a key extension point.

tdashworth avatar Nov 12 '21 14:11 tdashworth

I also ran into this and got quite frustrated. Writing Yeoman generators is already a bit difficult, but writing a custom cli Frontend for a set of generators is nearly impossible if Your Typescript compiler tells you there are issues that practically only exist in the type definition files, but not in the code of itself.

Still thanks a lot for developing and maintaining Yeoman, it seems to be one of the only reasonable tools on the market (besides degit, which has a different approach).

tburny avatar Nov 17 '21 21:11 tburny

I finally found some time to refactor the type declarations of yeoman-environment. I opened up a new PR just a few seconds ago. Stay tuned.

https://github.com/DefinitelyTyped/DefinitelyTyped/pull/58614

manuth avatar Feb 04 '22 23:02 manuth

That's amazing! Thank you @manuth, I'll take a look now.

tdashworth avatar Feb 05 '22 08:02 tdashworth

yeoman-enviroment has built-in types now.

mshima avatar Jan 15 '24 14:01 mshima