lunisolar icon indicating copy to clipboard operation
lunisolar copied to clipboard

stem and branch are incorrect

Open techlearn-grmd opened this issue 7 years ago • 0 comments

Hi, thank you for sharing this library. I rarely found package with stem, and branch info, and so glad you included in this package. I just want to raise an issue about stem and branch, for the most part (of the year), this package is correct, BUT the stem and branch information are incorrectly returned at year transition, per official Chinese calendar, transition to new year (new stem/branch) happens on lichun (1st day of spring), not first day of the year. For example, in 2018, lichun happens on Feb 4th, 2018, while first day of Chinese new year is Feb 16th, 2018.

Reference: https://zhidao.baidu.com/question/133315233.html

Appreciate your attention. Cheers.

techlearn-grmd avatar Feb 12 '18 15:02 techlearn-grmd