Yasser Elsayed
Yasser Elsayed
agreed, I think we could use some review of all error messages, and maybe better type-checking as well (maybe add an enum for errors?).
can you explain more what you have in mind? I thought you just meant going over the error strings we're returning to make sure they're useful.
it's a good find. the problem with these libraries is they're pretty opinionated, and they end up shaping your code in a way you don't necessarily like, and now newcomers...
@mohamedsaleh1984 Gentle ping on this, could you follow up with the comments so we can get this merged? Let me know if you need some help with it. :)
Understood, no worries. I'll proceed with other changes then you can rebase or merge when you're ready to continue. :)
I created https://github.com/yebrahim/codersquare/pull/12 to mirror your changes here since you'll need to rebase in order to merge this pull request. We can choose to merge that one instead (https://github.com/yebrahim/codersquare/pull/12), which...
@MoustafaJazzar I'd like to move forward with the next parts, namely adding proper authentication. Would you be able to handle the comments and merge this PR soon? Otherwise you could...
@rickymarcon can you explain how to use this? Where should I put it?
Never mind, worked when put before the element's class declaration. However, I'm using Typescript with Polymer, and seeing a similar error with a few other classes randomly. For example, for...