ENH: add option for custom delim

[erfannariman]

Option to add a custom delimiter, as long as it ASCII. This is better than allowing all ASCII characters.

Still to be tested, but opening this PR so you can have a look and comment.

[codecov[bot]]

Codecov Report

Merging #22 (59a9b69) into master (e461124) will decrease coverage by 5.75%. The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master      #22      +/-   ##
==========================================
- Coverage   97.27%   91.52%   -5.76%     
==========================================
  Files           2        4       +2     
  Lines         147      236      +89     
==========================================
+ Hits          143      216      +73     
- Misses          4       20      +16     

Impacted Files	Coverage Δ
bcpandas/main.py	95.61% <66.66%> (-0.82%)	:arrow_down:
bcpandas/utils.py	82.89% <0.00%> (ø)
bcpandas/__init__.py	81.81% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update db37a2c...59a9b69. Read the comment docs.

[yehoshuadimarsky]

Great start, and thanks for the PR. Overall looks good, just a few comments

• Can we somehow incorporate passing the custom delimiter to the get_* functions in order to ensure that they don't already appear in the actual data (which would make them not work)? https://github.com/yehoshuadimarsky/bcpandas/blob/db37a2c1ffba7f19a01019b833ba526622ae577c/bcpandas/constants.py#L64-L75
• Yes, if possible please include a test in the PR for the new functionality.

Again, thanks for the contribution!

[erfannariman]

@yehoshuadimarsky not sure, but is this not solved in #39

[yehoshuadimarsky]

closing this, appears abandoned. You are welcome to re-open it if you want to revisit this