qulice icon indicating copy to clipboard operation
qulice copied to clipboard

Name 'id' must match pattern '^[a-z]{2,}[a-zA-Z]+$'. (MethodNameCheck)

Open dgroup opened this issue 6 years ago • 24 comments
trafficstars

Hi Guys, What is the business purpose of this check for the fields and methods with name equal to id? This name quite self-explaining.

The same is related to PMD

  • Field id has the same name as a method (AvoidFieldNameMatchingMethodName)
  • Avoid using short method names (ShortMethodName)

Why it can't be added into exclusions?

dgroup avatar Dec 07 '18 09:12 dgroup

@krzyk/z please, pay attention to this issue

0crat avatar Dec 07 '18 09:12 0crat

@dgroup/z this project will fix the problem faster if you donate a few dollars to it; just click here and pay via Stripe, it's very fast, convenient and appreciated; thanks a lot!

0crat avatar Dec 07 '18 09:12 0crat

@dgroup makes sense (considering that we already have https://github.com/teamed/qulice/issues/593)

krzyk avatar Dec 07 '18 09:12 krzyk

@0crat in

krzyk avatar Dec 07 '18 09:12 krzyk

@krzyk no response from 0crat more than 7 min. Looks like 0crat went into the infinitive loop due to your #960 self-link :)

dgroup avatar Dec 07 '18 09:12 dgroup

@0crat in (here)

@krzyk Job #960 is now in scope, role is DEV

0crat avatar Dec 07 '18 10:12 0crat

Bug was reported, see §29: +15 point(s) just awarded to @dgroup/z

0crat avatar Dec 07 '18 10:12 0crat

Also, I think the same situation with field/method equal to name. That's also quite self-explaining.

dgroup avatar Dec 07 '18 12:12 dgroup

The job #960 assigned to @paulodamaso/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be no monetary reward for this job

0crat avatar Jan 24 '19 10:01 0crat

@krzyk I believe that it has already been resolved in the linked PRs, what should I do here?

paulodamaso avatar Jan 27 '19 03:01 paulodamaso

@paulodamaso there wasn't any PR here, the linked issue is for slightly different problem

krzyk avatar Jan 28 '19 13:01 krzyk

@krzyk OK,thanks, I'll take a look soon

paulodamaso avatar Jan 28 '19 15:01 paulodamaso

@0crat refuse

paulodamaso avatar Feb 03 '19 17:02 paulodamaso

@0crat refuse (here)

@paulodamaso The user @paulodamaso/z resigned from #960, please stop working. Reason for job resignation: Order was cancelled

0crat avatar Feb 03 '19 17:02 0crat

Tasks refusal is discouraged, see §6: -15 point(s) just awarded to @paulodamaso/z

0crat avatar Feb 03 '19 17:02 0crat

@krzyk/z everybody who has role DEV is banned at #960; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

0crat avatar Feb 03 '19 17:02 0crat

@krzyk/z everybody who has role DEV is banned at #960; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

0crat avatar Feb 08 '19 18:02 0crat

@krzyk/z everybody who has role DEV is banned at #960; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

0crat avatar Feb 13 '19 19:02 0crat

@krzyk/z everybody who has role DEV is banned at #960; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

0crat avatar Feb 18 '19 21:02 0crat

@krzyk/z everybody who has role DEV is banned at #960; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

0crat avatar Feb 23 '19 22:02 0crat

@krzyk/z everybody who has role DEV is banned at #960; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

0crat avatar Feb 28 '19 23:02 0crat

@krzyk/z everybody who has role DEV is banned at #960; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

0crat avatar Mar 06 '19 00:03 0crat

@krzyk/z everybody who has role DEV is banned at #960; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

0crat avatar Mar 11 '19 01:03 0crat

@krzyk/z everybody who has role DEV is banned at #960; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

0crat avatar Mar 16 '19 02:03 0crat