qulice icon indicating copy to clipboard operation
qulice copied to clipboard

LineLengthCheck check doubles non-ASCII symbols

Open proshin-roman opened this issue 7 years ago • 7 comments

What's wrong I have next line in the code (keeping indentation):

        final String input = "Hello, товарищ output äÄ üÜ öÖ and ß";

This line has 68 chars length and contains 14 non-ASCII symbols. Then I run the build with qulice maven plugin (version 0.17.1; OS Windows 10; standard command line) and get next error:

[INFO] Checkstyle: <class name>.java[83]: Line is longer than 80 characters (found 82). (LineLengthCheck)

It says the length is 82 that means that non-ASCII symbols are calculated twice: 68 (including non-ASCII) + 14 (doubled non-ASCII symbols) = 82. It's a bug!

How it should be All symbols must be calculated in same way and once only.

proshin-roman avatar Feb 22 '18 19:02 proshin-roman

@krzyk/z please, pay attention to this issue

0crat avatar Feb 22 '18 19:02 0crat

@proshin-roman The issue here is actually in checkstyle, have you checked there if they already fixed this bug?

krzyk avatar Apr 27 '18 10:04 krzyk

@krzyk It might be this issue https://github.com/checkstyle/checkstyle/issues/5089

proshin-roman avatar Apr 27 '18 12:04 proshin-roman

@proshin-roman So not much we can do here right now until it is fixed in checkstyle :(

krzyk avatar Apr 27 '18 12:04 krzyk

@krzyk Yes, I agree but I would prefer to keep the ticket open so that we don't forget about this problem. And then it can be closed as soon as qulice is upgraded to the fixed Checkstyle version.

proshin-roman avatar Apr 27 '18 12:04 proshin-roman

The bug is reproduced in the build: http://www.rultor.com/t/14467-387496260

lrozenblyum avatar May 08 '18 18:05 lrozenblyum

+1 for this issue.

QwerTech avatar Jan 13 '19 00:01 QwerTech