qulice
qulice copied to clipboard
IndentationCheck is wrong for annotaions
This code should pass the check (Now it fails):
@SuppressWarnings(
{
"PMD.TooManyMethods",
"PMD.ExcessiveImports",
"PMD.AvoidDuplicateLiterals"
}
)
public final class Test {}
')' have incorrect indentation level 0, expected level should be 4. (IndentationCheck)
This code should fail the check (now it pass):
@SuppressWarnings(
{
"PMD.TooManyMethods",
"PMD.ExcessiveImports",
"PMD.AvoidDuplicateLiterals"
}
)
public final class Test {}
@longtimeago I will find a developer for the task soon...
@longtimeago thanks for tis bug, I topped your account for 15 mins, transaction 55913385
@davvd this issue depends on checkstyle/checkstyle#1349 (and checkstyle release after that)
@davvd this is postponed
@davvd this is postponed
@krzyk right, I added "postponed" label
@davvd this is postponed
@krzyk I will ask somebody else to pick this up
@krzyk I'd like to take this one too
@davvd this is not postponed
@davvd assign @mkordas please
@davvd this is not postponed
@krzyk thanks, I removed the "postponed" tag
@davvd assign @mkordas please
@krzyk done. @mkordas the task is yours, please go ahead
@davvd I need more time here, we need to wait for Checkstyle 6.15 being released with the fix
@davvd I need more time here, we need to wait for Checkstyle 6.15 being released with the fix
@mkordas of course, thanks for letting me know, take your time
@longtimeago are you sure this bug is still present? I use it like this, without issues:
@SuppressWarnings
(
{
"PMD.TooManyMethods",
"PMD.ExcessiveImports",
"PMD.AvoidDuplicateLiterals"
}
)
public final class Test {}
@yegor256 your version works fine, but the code below fails (and it will pass with Checkstyle 6.15)
@SuppressWarnings(
{
"PMD.TooManyMethods",
"PMD.ExcessiveImports",
"PMD.AvoidDuplicateLiterals"
}
) // violation
public final class Test {}
@mkordas Am I correct that new checkstyle will be released no sooner than about 15 days?
@krzyk yes - I helped to develop the fix for this issue in Checkstyle, but releases are at the end of each month so we need to wait
@mkordas so I would put this one back to postponed and assign to you when the checkstyle is released (I would probably need a ping :) ), unless you prefer to leave it as it is right now
@krzyk yes, that would be perfect
@davvd this is postponed
@davvd this is postponed
@krzyk got it, "postponed" label here
@davvd this is postponed
@krzyk I will ask somebody else to pick this up
@mkordas new checkstyle has been released, can you take this?
@krzyk sure, I'll take that just after @davvd assigns reviewer to #681
@davvd this is not postponed
@davvd this is not postponed
@krzyk got it, "postponed" tag removed from here
@davvd assign @mkordas
@davvd assign @mkordas
@krzyk there are already 11 active tasks in the project, we can't have more
@davvd could you list the "active tasks", I see only 7 active (3 pull requests and 4 issues).
@longtimeago once 411-71c8871e
puzzle is resolved (later, in another ticket), this ticket will be fully complete