qulice icon indicating copy to clipboard operation
qulice copied to clipboard

IndentationCheck is wrong for annotaions

Open longtimeago opened this issue 9 years ago • 37 comments

This code should pass the check (Now it fails):

@SuppressWarnings(
    {
        "PMD.TooManyMethods",
        "PMD.ExcessiveImports",
        "PMD.AvoidDuplicateLiterals"
    }
)
public final class Test {}
')' have incorrect indentation level 0, expected level should be 4. (IndentationCheck)

This code should fail the check (now it pass):

@SuppressWarnings(
    {
        "PMD.TooManyMethods",
        "PMD.ExcessiveImports",
        "PMD.AvoidDuplicateLiterals"
    }
    )
public final class Test {}

longtimeago avatar Mar 02 '15 20:03 longtimeago

@longtimeago I will find a developer for the task soon...

davvd avatar Apr 22 '15 08:04 davvd

@longtimeago thanks for tis bug, I topped your account for 15 mins, transaction 55913385

davvd avatar Apr 22 '15 08:04 davvd

@davvd this issue depends on checkstyle/checkstyle#1349 (and checkstyle release after that)

krzyk avatar Nov 02 '15 11:11 krzyk

@davvd this is postponed

krzyk avatar Nov 03 '15 09:11 krzyk

@davvd this is postponed

@krzyk right, I added "postponed" label

davvd avatar Nov 04 '15 12:11 davvd

@davvd this is postponed

@krzyk I will ask somebody else to pick this up

davvd avatar Nov 04 '15 12:11 davvd

@krzyk I'd like to take this one too

mkordas avatar Dec 30 '15 08:12 mkordas

@davvd this is not postponed

krzyk avatar Dec 30 '15 08:12 krzyk

@davvd assign @mkordas please

krzyk avatar Dec 30 '15 08:12 krzyk

@davvd this is not postponed

@krzyk thanks, I removed the "postponed" tag

davvd avatar Dec 30 '15 11:12 davvd

@davvd assign @mkordas please

@krzyk done. @mkordas the task is yours, please go ahead

davvd avatar Dec 30 '15 11:12 davvd

@davvd I need more time here, we need to wait for Checkstyle 6.15 being released with the fix

mkordas avatar Dec 31 '15 20:12 mkordas

@davvd I need more time here, we need to wait for Checkstyle 6.15 being released with the fix

@mkordas of course, thanks for letting me know, take your time

davvd avatar Jan 01 '16 07:01 davvd

@longtimeago are you sure this bug is still present? I use it like this, without issues:

@SuppressWarnings
    (
        {
            "PMD.TooManyMethods",
            "PMD.ExcessiveImports",
            "PMD.AvoidDuplicateLiterals"
        }
    )
public final class Test {}

yegor256 avatar Jan 14 '16 22:01 yegor256

@yegor256 your version works fine, but the code below fails (and it will pass with Checkstyle 6.15)

@SuppressWarnings(
    {
        "PMD.TooManyMethods",
        "PMD.ExcessiveImports",
        "PMD.AvoidDuplicateLiterals"
    }
) // violation
public final class Test {}

mkordas avatar Jan 14 '16 22:01 mkordas

@mkordas Am I correct that new checkstyle will be released no sooner than about 15 days?

krzyk avatar Jan 15 '16 12:01 krzyk

@krzyk yes - I helped to develop the fix for this issue in Checkstyle, but releases are at the end of each month so we need to wait

mkordas avatar Jan 15 '16 12:01 mkordas

@mkordas so I would put this one back to postponed and assign to you when the checkstyle is released (I would probably need a ping :) ), unless you prefer to leave it as it is right now

krzyk avatar Jan 15 '16 12:01 krzyk

@krzyk yes, that would be perfect

mkordas avatar Jan 15 '16 13:01 mkordas

@davvd this is postponed

krzyk avatar Jan 15 '16 13:01 krzyk

@davvd this is postponed

@krzyk got it, "postponed" label here

davvd avatar Jan 18 '16 08:01 davvd

@davvd this is postponed

@krzyk I will ask somebody else to pick this up

davvd avatar Jan 18 '16 08:01 davvd

@mkordas new checkstyle has been released, can you take this?

krzyk avatar Feb 03 '16 11:02 krzyk

@krzyk sure, I'll take that just after @davvd assigns reviewer to #681

mkordas avatar Feb 04 '16 10:02 mkordas

@davvd this is not postponed

krzyk avatar Feb 05 '16 18:02 krzyk

@davvd this is not postponed

@krzyk got it, "postponed" tag removed from here

davvd avatar Feb 08 '16 09:02 davvd

@davvd assign @mkordas

krzyk avatar Feb 08 '16 14:02 krzyk

@davvd assign @mkordas

@krzyk there are already 11 active tasks in the project, we can't have more

davvd avatar Feb 09 '16 07:02 davvd

@davvd could you list the "active tasks", I see only 7 active (3 pull requests and 4 issues).

krzyk avatar Feb 09 '16 08:02 krzyk

@longtimeago once 411-71c8871e puzzle is resolved (later, in another ticket), this ticket will be fully complete

davvd avatar Feb 10 '16 08:02 davvd