hoc icon indicating copy to clipboard operation
hoc copied to clipboard

HOC produces broken git command for Windows

Open SimonHarmonicMinor opened this issue 3 years ago • 1 comments

Internally HOC produces the git command. The problem here is about these three arguments --author, --since, and --before. The lib adds additional quotes that cover each command which makes it impossible to use it on Windows.

The HOC shorten output:

git log '--author=@author' '--since=@since' '--before=@before' -- .

For instance, that's the output with quoted --author argument on Windows applied to HOC repository itself.

git log '--author=yegor256' -- .

fatal: bad revision ''--author=yegor256''

But if we remove the single quotes, everything becomes to work correctly.

git log --author=yegor256 -- .

commit a51114c6688bfd88748a8d4538b94101ed9376d0 (HEAD -> master, origin/master, origin/HEAD)
Author: yegor256 <[email protected]>
Date:   Wed Aug 5 16:07:02 2020 +0300

    #21 one dep off

commit 684c8ca79d79c7e7369fe671c161b98839c28ae1
Author: yegor256 <[email protected]>
Date:   Wed Aug 5 15:59:38 2020 +0300
...

I consider that the lib should not produce additional single quotes so that it can be used on Windows as well.

SimonHarmonicMinor avatar May 04 '21 19:05 SimonHarmonicMinor

I have the same problem. It would be great to get fix.

Gmugra avatar May 17 '21 17:05 Gmugra