cactoos icon indicating copy to clipboard operation
cactoos copied to clipboard

1586 Continue migration of tests to JUnit 5 for org.cactoos.func package

Open aakachurin opened this issue 3 years ago • 4 comments

For #1586:

  • Junit5 migration for UncheckedFuncTest
  • Junit5 migration for UncheckedBiFuncTest
  • Junit5 migration for TimedFuncTest
  • Junit5 migration for IoCheckedBiFuncTest
  • Junit5 migration for FuncWithFallbackTest
  • Junit5 migration for FuncNoNullsTest
  • Junit5 migration for CheckedFuncTest
  • Junit5 migration for CheckedBiFuncTest
  • Junit5 migration for BiFuncNoNullsTest
  • Junit5 migration for BytesTes

aakachurin avatar Dec 24 '21 21:12 aakachurin

@kachurinaa thank you for your contribution.

If you are still up to it, could you fix the conflict and also update the todo so that this one is closed and a new one is created? It's enough to just change the reference of the ticket of the todo in the pom.xml file from #1453 to #1586.

victornoel avatar Jul 18 '22 16:07 victornoel

@victornoel could you please approve it if it's ok?

aakachurin avatar Jul 19 '22 14:07 aakachurin

@kachurinaa very nice, thank you! It looks good, I will merge it after the CI has passed

victornoel avatar Jul 19 '22 14:07 victornoel

@rultor merge

victornoel avatar Jul 20 '22 12:07 victornoel