jupyterlab-neon-theme icon indicating copy to clipboard operation
jupyterlab-neon-theme copied to clipboard

Theme is applied to JupyterLab's UI even when it is not the selected theme

Open norweeg opened this issue 4 years ago • 5 comments
trafficstars

I have a different theme selected at the moment, however jupyterlab_neon_theme is still styling UI elements

image

image Python 3.9.6 Node v16.5.0

norweeg avatar Jul 28 '21 17:07 norweeg

Sorry for that. It happened when I used jupyter labextension develop --overwrite . 

How did you install the neon theme, via jupyter labextension install or something else?

---Original--- From: "Brennen @.> Date: Thu, Jul 29, 2021 01:12 AM To: @.>; Cc: @.***>; Subject: [yeebc/jupyterlab-neon-theme] Theme is applied to JupyterLab's UI even when it is not the selected theme (#18)

I have a different theme selected at the moment, however jupyterlab_neon_theme is still styling UI elements

Python 3.9.6 Node v16.5.0

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

yeebc avatar Jul 29 '21 00:07 yeebc

I don't remember. I installed it some time ago and did not uninstall it. I recently updated my JupyterLab, so as a matter of habit, I also ran jupyter labextension update --all and jupyter lab build afterwards

norweeg avatar Jul 29 '21 12:07 norweeg

i have the same issue. installed with this command:

jupyter labextension install @yeebc/jupyterlab_neon_theme

JupyterLab version 3.1.7

Additionally JupyterLab Vim extension stopped working. I uninstalled the Neon theme and after that JupyterLab Vim is back. Uinstalled it with:

jupyter labextension uninstall @yeebc/jupyterlab_neon_theme

miwojc avatar Oct 22 '21 12:10 miwojc

Same issue here. I installed via JupyterLab extension manager and jupyter lab build.

Edit: Miami Nights fork has a similar issue.

dd-ugm avatar Apr 17 '22 23:04 dd-ugm

See the updated docs here: https://jupyterlab.readthedocs.io/en/stable/extension/extension_dev.html#theme-plugins

Theme CSS assets are specially bundled in an extension (see Theme path) so they can be unloaded or loaded as the theme is activated. Since CSS files referenced by the style or styleModule keys are automatically bundled and loaded on the page, the theme files should not be referenced by these keys.

I think the fix is to remove the "style" key from package.json.

vidartf avatar Jun 28 '22 12:06 vidartf