yearn-vaults-v2-subgraph icon indicating copy to clipboard operation
yearn-vaults-v2-subgraph copied to clipboard

StrategyReportResult.duration measured in milliseconds instead of days

Open bsamuels453 opened this issue 3 years ago • 2 comments

StrategyReportResult.duration is supposed to be measured in days, according to its documentation. It is currently measured in milliseconds. Either convert this field to measure the duration in days, or change the documentation to reflect its unit of measure.

Make sure upstream usages of this field in yearn-watch and yearn-sdk aren't impacted

bsamuels453 avatar Feb 12 '22 02:02 bsamuels453

Which documentation are you referring to?

0xbok avatar Mar 04 '22 18:03 0xbok

@0xbok https://github.com/yearn/yearn-vaults-v2-subgraph/blob/main/schema.graphql#L509-L510

bsamuels453 avatar Mar 05 '22 02:03 bsamuels453