yearn-vaults-v2-subgraph icon indicating copy to clipboard operation
yearn-vaults-v2-subgraph copied to clipboard

AccountVaultPosition.balanceProfit returns inaccurate results when testing deposits

Open bsamuels453 opened this issue 3 years ago • 2 comments

When performing a basic deposit() test, AccountVaultPosition.balanceProfit records the deposited amount as profit.

This value should be 0 as there has been no profit recognized by the vault in the conditions set up by the test.

bsamuels453 avatar Dec 10 '21 21:12 bsamuels453

seems this todo is gone. can we close?

0xkofee avatar Apr 30 '22 01:04 0xkofee

I think this one is still not solved. The test this issue is about is commented out. You can find it at line 24 in this file

AlexNi245 avatar Apr 30 '22 12:04 AlexNi245