yearn-finance-v3
yearn-finance-v3 copied to clipboard
fix: Filter zapable token for wallet
Description
- Added
filter
to filter only zapable tokens - Checked that sUSD is not zapable in yearn-sdk
- Checked that sUSD yVault is not deprecated
Related Issue
- Fixes #683
Motivation and Context
- Improve user experience by not showing unzapable vaults
How Has This Been Tested?
- Locally by confirming sUSD not appearing in the wallet container
Screenshots (if appropriate):
-
sUSD yVault is shown to be not deprecated by checking AddressesGenerator_VAULT_V2's
assetDeprecated
and confirming vault is being fetched by checkingassetsAddresses
- sUSD token not showing anymore
This pull request is automatically being deployed by Amplify Hosting (learn more).
Access this pull request here: https://pr-688.d27dgpz01hmbvx.amplifyapp.com
We will be using the new zap properties, which will most likely deprecate the
isZapable
property.
I assume the new prop for the TokenView
type will be sourceIsZapper
. Could it just replace isZapable
? Because I realize there are tokens where their isZapable
is true
, but their sourceIsZapper
is false
. Thanks
We will be using the new zap properties, which will most likely deprecate the
isZapable
property.I assume the new prop for the
TokenView
type will besourceIsZapper
. Could it just replaceisZapable
? Because I realize there are tokens where theirisZapable
istrue
, but theirsourceIsZapper
isfalse
. Thanks
No, sourceIsZapper
will probably be deprecated as well. We're changing the whole way this is working, it's currently in progress as I'm working on the frontend bit as we speak, we'll most likely use the supported
prop which in turn has zapperZapIn
/zapperZapOut
/ftmApeZap
and other zaps. Thanks for having a look at this @huggingbot but let's have this on hold for the time being.