yearn-finance-v3 icon indicating copy to clipboard operation
yearn-finance-v3 copied to clipboard

fix: Filter zapable token for wallet

Open huggingbot opened this issue 2 years ago • 3 comments

Description

  • Added filter to filter only zapable tokens
  • Checked that sUSD is not zapable in yearn-sdk
  • Checked that sUSD yVault is not deprecated

Related Issue

  • Fixes #683

Motivation and Context

  • Improve user experience by not showing unzapable vaults

How Has This Been Tested?

  • Locally by confirming sUSD not appearing in the wallet container

Screenshots (if appropriate):

AddressesGenerator_VAULT_V2_0x437758d475f70249e03eda6be23684ad1fc375f0

  • sUSD token not showing anymore

susd

huggingbot avatar May 19 '22 12:05 huggingbot

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-688.d27dgpz01hmbvx.amplifyapp.com

We will be using the new zap properties, which will most likely deprecate the isZapable property.

I assume the new prop for the TokenView type will be sourceIsZapper. Could it just replace isZapable? Because I realize there are tokens where their isZapable is true, but their sourceIsZapper is false. Thanks

huggingbot avatar May 21 '22 04:05 huggingbot

We will be using the new zap properties, which will most likely deprecate the isZapable property.

I assume the new prop for the TokenView type will be sourceIsZapper. Could it just replace isZapable? Because I realize there are tokens where their isZapable is true, but their sourceIsZapper is false. Thanks

No, sourceIsZapper will probably be deprecated as well. We're changing the whole way this is working, it's currently in progress as I'm working on the frontend bit as we speak, we'll most likely use the supported prop which in turn has zapperZapIn/zapperZapOut/ftmApeZap and other zaps. Thanks for having a look at this @huggingbot but let's have this on hold for the time being.

karelianpie avatar May 22 '22 00:05 karelianpie