my_nautilus_scripts
my_nautilus_scripts copied to clipboard
yeKcim
Subtitle download
Would you be interested to integrate this https://github.com/manojmj92/subtitle-downloader as well ?
Yeah a tidy up is needed for sure.
I'm just using your repo and did not wanted to fork just for this one function, but would not do the job of the refactoring if you will never merge.
But in that case I will tidy up the code into one file and send you a PR "soon".
Maybe this one would work then?
https://github.com/emericg/OpenSubtitlesDownload
It's a single file. I'm using it since several months, manually placed into ~./local/share/nautilus/scripts/videos, no particular issue.
kisst [email protected] wrote:
Yeah a tidy up is needed for sure.
I'm just using your repo and did not wanted to fork just for this one function, but would not do the job of the refactoring if you will never merge.
But in that case I will tidy up the code into one file and send you a PR "soon".
Whichever works I'm easy on it, the one thing is behind the first option is the support for different endpoints ( api.thesubdb.com, subscene.com ) but I guess opensubtitle can be good as well, plus the gui for the select and etc looks very good on the @Kabouik suggestion.
As it looks pretty advance already, and might be under active development... @yeKcim would you prefer a git submodule or copy over "clone" ?