Ye Luo
Maybe we can just implement getGroupSizes by constructing vector on the fly.
getGroupSizes -> buildGroupSizeVec to indicate it is not an accessor
@jtkrogel We do have MPC working in the batched code. https://cdash.qmcpack.org/CDash/testDetails.php?test=17171347&build=293503 It seems being added to auxH. It is likely being labelled as hamiltonian non phsyical rather than an estimator.
Named arguments seem much more readable when there are like 10+ arguments.
I disagree. This is a designed feature. All the variational parameters should be under shared_ptr. All the SPOSet objects with the same name must be cloned from the same object...
"Then all the SPOSets get rotated by number of clones * some_rotation." Did you forget the "gold" object, the optimizer is supposed to touch that one instead of bookkeeping individual...
I'm not sure if we'd like to do rebase. merge develop into the feature branch is more common.
@LeonOtis could you make a new branch from develop and cherry pick the last fix commit you pushed and then make a separate PR.
@LeonOtis I will make a review of this PR within this week. Q: with the current develop, does the "hybrid" method working with batched driver? When you made the fix...
> @ye-luo The hybrid method should work with the batched driver. I've now added a test for it on H4, similar to what I previously added for the legacy driver....