UnifiedLogReader
UnifiedLogReader copied to clipboard
VirtualFileSystem.get_virtual_file() will return a VirtualFile for a path to a directory
VirtualFileSystem.get_virtual_file() will return a VirtualFile for a path to a directory
Unclear from the code and docstring what the intended behavior is
That should have said ..path to a file instead of ..path to a directory. It will create an object of type VirtualFile and return it. I will change the description to a better one.
Or adding a docstring with some additional checks to see path points to file could help as well. Per email I would focus on adding tests first, then have a closer look at improving the interfaces