UnifiedLogReader icon indicating copy to clipboard operation
UnifiedLogReader copied to clipboard

VirtualFileSystem.get_virtual_file() will return a VirtualFile for a path to a directory

Open joachimmetz opened this issue 6 years ago • 2 comments

VirtualFileSystem.get_virtual_file() will return a VirtualFile for a path to a directory

Unclear from the code and docstring what the intended behavior is

joachimmetz avatar Feb 02 '19 11:02 joachimmetz

That should have said ..path to a file instead of ..path to a directory. It will create an object of type VirtualFile and return it. I will change the description to a better one.

ydkhatri avatar Feb 03 '19 01:02 ydkhatri

Or adding a docstring with some additional checks to see path points to file could help as well. Per email I would focus on adding tests first, then have a closer look at improving the interfaces

joachimmetz avatar Feb 03 '19 07:02 joachimmetz