ydb
ydb copied to clipboard
ydb-platform
Add analytical nodes to kqp
:white_circle: 2024-04-26 10:12:49 UTC Pre-commit check for 7b1cce7bb57925ac399a28d30461fdb6431f868b has started.
:white_circle: 2024-04-26 10:12:50 UTC Build linux-x86_64-release-asan is running...
:black_circle: 2024-04-26 10:22:53 UTC Check cancelled
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
:white_circle: 2024-04-26 10:13:05 UTC Pre-commit check for 7b1cce7bb57925ac399a28d30461fdb6431f868b has started.
:white_circle: 2024-04-26 10:13:06 UTC Build linux-x86_64-release-clang14 is running...
:black_circle: 2024-04-26 10:22:54 UTC Check cancelled
:white_circle: 2024-04-26 10:14:27 UTC Pre-commit check for 7b1cce7bb57925ac399a28d30461fdb6431f868b has started.
:white_circle: 2024-04-26 10:14:29 UTC Build linux-x86_64-relwithdebinfo is running...
:black_circle: 2024-04-26 10:22:53 UTC Check cancelled
:white_circle: 2024-04-26 10:24:05 UTC Pre-commit check for 9d056b86f17520bd5801de86b2b0f89bc121f8a7 has started.
:white_circle: 2024-04-26 10:24:06 UTC Build linux-x86_64-release-clang14 is running...
:green_circle: 2024-04-26 10:57:13 UTC Build successful.
:white_circle: 2024-04-26 10:27:00 UTC Pre-commit check for 9d056b86f17520bd5801de86b2b0f89bc121f8a7 has started.
:white_circle: 2024-04-26 10:27:02 UTC Build linux-x86_64-relwithdebinfo is running...
:green_circle: 2024-04-26 11:04:24 UTC Build successful.
:white_circle: 2024-04-26 11:06:12 UTC Tests are running...
:red_circle: 2024-04-26 11:10:55 UTC Test run completed, no test results found for commit 52cfbcf58e61383e9d37853b9627e9a73dea425a. Please check build logs.
:black_circle: 2024-04-26 11:10:57 UTC Check cancelled
:white_circle: 2024-04-26 10:28:59 UTC Pre-commit check for 9d056b86f17520bd5801de86b2b0f89bc121f8a7 has started.
:white_circle: 2024-04-26 10:29:01 UTC Build linux-x86_64-release-asan is running...
:green_circle: 2024-04-26 11:06:45 UTC Build successful.
:white_circle: 2024-04-26 11:08:34 UTC Tests are running...
:red_circle: 2024-04-26 11:10:56 UTC Test run completed, no test results found for commit 52cfbcf58e61383e9d37853b9627e9a73dea425a. Please check build logs.
:black_circle: 2024-04-26 11:10:59 UTC Check cancelled
:white_circle: 2024-04-26 11:12:59 UTC Pre-commit check for 7e5332866b1b20b202cbbae754ae4ca719040f35 has started.
:white_circle: 2024-04-26 11:13:01 UTC Build linux-x86_64-release-asan is running...
:green_circle: 2024-04-26 11:49:12 UTC Build successful.
:white_circle: 2024-04-26 11:50:55 UTC Tests are running...
:red_circle: 2024-04-26 13:33:44 UTC Some tests failed, follow the links below.
| TESTS | PASSED | ERRORS | FAILED | SKIPPED | MUTED? |
|---|---|---|---|---|---|
| 10261 | 10072 | 0 | 29 | 129 | 31 |
:white_circle: 2024-04-26 11:14:32 UTC Pre-commit check for 7e5332866b1b20b202cbbae754ae4ca719040f35 has started.
:white_circle: 2024-04-26 11:14:34 UTC Build linux-x86_64-release-clang14 is running...
:green_circle: 2024-04-26 11:50:45 UTC Build successful.
:white_circle: 2024-04-26 11:30:16 UTC Pre-commit check for 7e5332866b1b20b202cbbae754ae4ca719040f35 has started.
:white_circle: 2024-04-26 11:30:17 UTC Build linux-x86_64-relwithdebinfo is running...
:green_circle: 2024-04-26 12:08:21 UTC Build successful.
:white_circle: 2024-04-26 12:10:37 UTC Tests are running...
:red_circle: 2024-04-26 13:44:24 UTC Some tests failed, follow the links below.
| TESTS | PASSED | ERRORS | FAILED | SKIPPED | MUTED? |
|---|---|---|---|---|---|
| 37502 | 32190 | 0 | 13 | 5273 | 26 |
Overall i think that PR is okay generally, however i think that the usage of "ServedWorkload" field isn't clear. I guess that we should introduce "NodeTags" field instead so that the resource manager will have an ability to assign specific tasks and queries to the nodes with the specific tag
how this field should be used in the future and how it can be extended in the future?
Basically there is also a huge a concern that we don't know exactly that queries are 100% analytical.
