ydb Get rid of unneccessary std::move

Fixes #1246

Compile-tested (ydb & ydbd)

Changelog entry

...

Changelog category

Not for changelog (changelog entry is not required)

Additional information

Rev 2: also changed

Bar foo(..., Bar && res,...) {
....
    return std::move(res);
}

Rev 3: reverted incorrect changes for Bar && foo(..., Bar &&,...)

Rev 4: completely reverted changes from rev.2/rev.3 (with Bar && res, expression res has type r-value reference, but value category of l-value; hence, std::move() must be used, and, part 2 was completely incorrect) Partially revert changes from first patch where local variable type mismatched returned type (std::move() must be used)

Apr 18 '24 17:04 yumkam

Hi! Thank you for contributing! The tests on this PR will run after a maintainer adds an ok-to-test label to this PR manually. Thank you for your patience!

Apr 18 '24 17:04 github-actions[bot]

:white_circle: 2024-05-06 21:14:39 UTC Pre-commit check for f8bb2323406af2c8d2679fe32897da7808862e80 has started. :white_circle: 2024-05-06 21:14:41 UTC Build linux-x86_64-release-clang14 is running... :red_circle: 2024-05-06 22:23:51 UTC Build failed. see the build logs.

May 06 '24 21:05 github-actions[bot]

:white_circle: 2024-05-06 21:14:54 UTC Pre-commit check for f8bb2323406af2c8d2679fe32897da7808862e80 has started. :white_circle: 2024-05-06 21:14:57 UTC Build linux-x86_64-relwithdebinfo is running... :red_circle: 2024-05-06 21:59:03 UTC Build failed. see the build logs. :red_circle: 2024-05-06 22:00:39 UTC Tests run skipped.

May 06 '24 21:05 github-actions[bot]

:white_circle: 2024-05-06 21:14:55 UTC Pre-commit check for f8bb2323406af2c8d2679fe32897da7808862e80 has started. :white_circle: 2024-05-06 21:14:57 UTC Build linux-x86_64-release-asan is running... :red_circle: 2024-05-06 22:00:28 UTC Build failed. see the build logs. :red_circle: 2024-05-06 22:02:09 UTC Tests run skipped.

May 06 '24 21:05 github-actions[bot]

Все же много лишних зачисток. Давайте внимательнее менять код, тем более, что его фиг оттестируешь

May 07 '24 06:05 uzhastik

:white_circle: 2024-05-07 12:32:54 UTC Pre-commit check for da080986b50ac9f34483293ac03f1eb4f02161df has started. :white_circle: 2024-05-07 12:32:57 UTC Build linux-x86_64-release-asan is running... :green_circle: 2024-05-07 13:11:08 UTC Build successful. :white_circle: 2024-05-07 13:12:57 UTC Tests are running... :red_circle: 2024-05-07 15:00:34 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
14666	14524	0	46	85	11

May 07 '24 12:05 github-actions[bot]

:white_circle: 2024-05-07 12:32:55 UTC Pre-commit check for da080986b50ac9f34483293ac03f1eb4f02161df has started. :white_circle: 2024-05-07 12:32:57 UTC Build linux-x86_64-release-clang14 is running... :green_circle: 2024-05-07 13:17:45 UTC Build successful.

May 07 '24 12:05 github-actions[bot]

:white_circle: 2024-05-07 12:35:08 UTC Pre-commit check for da080986b50ac9f34483293ac03f1eb4f02161df has started. :white_circle: 2024-05-07 12:35:11 UTC Build linux-x86_64-relwithdebinfo is running... :green_circle: 2024-05-07 13:13:58 UTC Build successful. :white_circle: 2024-05-07 13:15:47 UTC Tests are running... :red_circle: 2024-05-07 15:14:26 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
73341	60214	0	7	13111	9

May 07 '24 12:05 github-actions[bot]

:white_circle: 2024-05-10 12:01:49 UTC Pre-commit check for e7e5107ef152a0615e83700c9b29510216708865 has started. :white_circle: 2024-05-10 12:01:50 UTC Build linux-x86_64-relwithdebinfo is running... :green_circle: 2024-05-10 12:31:53 UTC Build successful. :white_circle: 2024-05-10 12:33:35 UTC Tests are running... :red_circle: 2024-05-10 12:38:10 UTC Test run completed, no test results found for commit dcbe42da0adf52ebe6d112e72087e5543130e2e3. Please check build logs. :black_circle: 2024-05-10 12:38:13 UTC Check cancelled