Fix grace join UUID encoding

[yumkam]

Changelog entry

Fix Uuid handling in mkql_grace_join

Changelog category

• Bugfix

Additional information

I noticed something weird while reading the code: I believe there are missing break; statement in handling Uuid's; also note mismatch between Uuid handling and string-alike handling, this is yet another bug (mostly easily fixed by unifying string-alike and Uuid handling). I added very crude test (just copied another and replaced strings with Uuid). It fails when applied alone, still fails with only break added, and passes with complete series applied. Compile-tested, limited runtime-tested (my machine is too weak to handle even single round of compilation).

[github-actions[bot]]

Hi! Thank you for contributing! The tests on this PR will run after a maintainer adds an ok-to-test label to this PR manually. Thank you for your patience!

[yumkam]

Also, why was not this bug (well, first half of this bug) caught in by static analysis (aka warning): it seems missing -Wimplicit-fallthrough (implied by -Wextra in gcc, but not in clang).

[github-actions[bot]]

:white_circle: 2024-05-06 21:17:04 UTC Pre-commit check for 347e262464f6bf3f3541777681f2e0fbbc9a0340 has started. :white_circle: 2024-05-06 21:17:05 UTC Build linux-x86_64-release-clang14 is running... :green_circle: 2024-05-06 22:32:03 UTC Build successful.

[github-actions[bot]]

:white_circle: 2024-05-06 21:17:12 UTC Pre-commit check for 347e262464f6bf3f3541777681f2e0fbbc9a0340 has started. :white_circle: 2024-05-06 21:17:14 UTC Build linux-x86_64-relwithdebinfo is running... :green_circle: 2024-05-06 21:20:29 UTC Build successful. :white_circle: 2024-05-06 21:22:11 UTC Tests are running... :red_circle: 2024-05-06 23:16:48 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED?
70025	56922	0	3	13087	13

[github-actions[bot]]

:white_circle: 2024-05-06 21:17:18 UTC Pre-commit check for 347e262464f6bf3f3541777681f2e0fbbc9a0340 has started. :white_circle: 2024-05-06 21:17:21 UTC Build linux-x86_64-release-asan is running... :green_circle: 2024-05-06 21:20:16 UTC Build successful. :white_circle: 2024-05-06 21:21:59 UTC Tests are running... :red_circle: 2024-05-06 23:11:18 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED?
11382	11266	0	41	65	10

[github-actions[bot]]

:white_circle: 2024-05-22 13:03:36 UTC Pre-commit check for aae6390a241057e83c28144430ae2b3b965ba0f0 has started. :white_circle: 2024-05-22 13:03:38 UTC Build linux-x86_64-relwithdebinfo is running... :green_circle: 2024-05-22 13:06:59 UTC Build successful. :white_circle: 2024-05-22 13:08:44 UTC Tests are running... :red_circle: 2024-05-22 15:01:37 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED?
70746	58047	0	2	12692	5

[github-actions[bot]]

:white_circle: 2024-05-22 13:04:19 UTC Pre-commit check for aae6390a241057e83c28144430ae2b3b965ba0f0 has started. :white_circle: 2024-05-22 13:04:21 UTC Build linux-x86_64-release-asan is running... :green_circle: 2024-05-22 13:08:23 UTC Build successful. :white_circle: 2024-05-22 13:10:12 UTC Tests are running... :red_circle: 2024-05-22 15:11:19 UTC Some tests failed, follow the links below.

Test history

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED?
11774	11666	0	37	60	11

[github-actions[bot]]

:white_circle: 2024-05-22 13:05:36 UTC Pre-commit check for aae6390a241057e83c28144430ae2b3b965ba0f0 has started. :white_circle: 2024-05-22 13:05:38 UTC Build linux-x86_64-release-clang14 is running... :green_circle: 2024-05-22 13:36:42 UTC Build successful.