ydb icon indicating copy to clipboard operation
ydb copied to clipboard

YQ-4263 PrivateApi: remove weak_from_this

Open kardymonds opened this issue 1 month ago • 4 comments

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

kardymonds avatar Dec 11 '25 19:12 kardymonds

Run Extra Tests

Run additional tests for this PR. You can customize:

  • Test Size: small, medium, large (default: all)
  • Test Targets: any directory path (default: ydb/)
  • Sanitizers: ASAN, MSAN, TSAN
  • Coredumps: enable for debugging (default: off)
  • Additional args: custom ya make arguments

▶  Run tests

ydbot avatar Dec 11 '25 19:12 ydbot

:white_circle: 2025-12-11 19:57:14 UTC Pre-commit check linux-x86_64-relwithdebinfo for a6ac288cb0e73381dffb62cdd6e155658b7ee146 has started. :white_circle: 2025-12-11 19:57:18 UTC Artifacts will be uploaded here :white_circle: 2025-12-11 19:58:35 UTC ya make is running... :yellow_circle: 2025-12-11 21:34:20 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39437 36509 0 5 2902 21

:white_circle: 2025-12-11 21:34:35 UTC ya make is running... (failed tests rerun, try 2) :green_circle: 2025-12-11 21:46:35 UTC Tests successful.

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
46 (only retried tests) 34 0 0 0 12

:green_circle: 2025-12-11 21:46:43 UTC Build successful. :green_circle: 2025-12-11 21:47:07 UTC ydbd size 2.3 GiB changed* by -2.7 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: eb4215208f11e020c3778e8cd4eb35c36a346c64 merge: a6ac288cb0e73381dffb62cdd6e155658b7ee146 diff diff %
ydbd size 2 468 609 720 Bytes 2 468 607 000 Bytes -2.7 KiB -0.000%
ydbd stripped size 525 315 584 Bytes 525 315 008 Bytes -576 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

github-actions[bot] avatar Dec 11 '25 19:12 github-actions[bot]

:green_circle: 2025-12-11 19:58:23 UTC The validation of the Pull Request description is successful.

github-actions[bot] avatar Dec 11 '25 19:12 github-actions[bot]

:white_circle: 2025-12-11 19:59:22 UTC Pre-commit check linux-x86_64-release-asan for a6ac288cb0e73381dffb62cdd6e155658b7ee146 has started. :white_circle: 2025-12-11 19:59:40 UTC Artifacts will be uploaded here :white_circle: 2025-12-11 20:01:50 UTC ya make is running... :yellow_circle: 2025-12-11 21:09:52 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11582 11487 0 74 12 9

:green_circle: 2025-12-11 21:10:00 UTC Build successful. :green_circle: 2025-12-11 21:10:30 UTC ydbd size 3.8 GiB changed* by -112 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: eb4215208f11e020c3778e8cd4eb35c36a346c64 merge: a6ac288cb0e73381dffb62cdd6e155658b7ee146 diff diff %
ydbd size 4 133 890 576 Bytes 4 133 890 464 Bytes -112 Bytes -0.000%
ydbd stripped size 1 534 412 504 Bytes 1 534 412 440 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

github-actions[bot] avatar Dec 11 '25 19:12 github-actions[bot]

:white_circle: 2025-12-15 08:55:38 UTC Pre-commit check linux-x86_64-release-asan for 8a37fbeec8facbf22e36a6e519a3ef5b7111c4d1 has started. :white_circle: 2025-12-15 08:55:57 UTC Artifacts will be uploaded here :white_circle: 2025-12-15 08:58:03 UTC ya make is running... :yellow_circle: 2025-12-15 10:03:42 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11611 11497 0 81 20 13

:green_circle: 2025-12-15 10:03:50 UTC Build successful. :green_circle: 2025-12-15 10:04:22 UTC ydbd size 3.9 GiB changed* by +7.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 79b76329d43f67b9730193d49e9c8788a46a26d2 merge: 8a37fbeec8facbf22e36a6e519a3ef5b7111c4d1 diff diff %
ydbd size 4 140 115 656 Bytes 4 140 123 744 Bytes +7.9 KiB +0.000%
ydbd stripped size 1 536 731 256 Bytes 1 536 735 960 Bytes +4.6 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

github-actions[bot] avatar Dec 15 '25 08:12 github-actions[bot]

:white_circle: 2025-12-15 08:55:46 UTC Pre-commit check linux-x86_64-relwithdebinfo for 8a37fbeec8facbf22e36a6e519a3ef5b7111c4d1 has started. :white_circle: 2025-12-15 08:56:03 UTC Artifacts will be uploaded here :white_circle: 2025-12-15 08:58:11 UTC ya make is running... :yellow_circle: 2025-12-15 10:36:12 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39483 36552 0 3 2903 25

:white_circle: 2025-12-15 10:36:35 UTC ya make is running... (failed tests rerun, try 2) :green_circle: 2025-12-15 10:51:15 UTC Tests successful.

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
48 (only retried tests) 35 0 0 0 13

:green_circle: 2025-12-15 10:51:22 UTC Build successful. :green_circle: 2025-12-15 10:51:44 UTC ydbd size 2.3 GiB changed* by +3.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 79b76329d43f67b9730193d49e9c8788a46a26d2 merge: 8a37fbeec8facbf22e36a6e519a3ef5b7111c4d1 diff diff %
ydbd size 2 473 774 728 Bytes 2 473 778 048 Bytes +3.2 KiB +0.000%
ydbd stripped size 526 651 168 Bytes 526 651 552 Bytes +384 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

github-actions[bot] avatar Dec 15 '25 08:12 github-actions[bot]

Backport

To backport this PR, click the button next to the target branch and then click "Run workflow" in the Run Actions UI.

Branch Run
stable-25-2, stable-25-2-1, stable-25-3, stable-25-3-1 ▶  Backport
stable-25-3, stable-25-3-1 ▶  Backport
stable-25-3 ▶  Backport

▶  Backport manual

ydbot avatar Dec 16 '25 10:12 ydbot