ydb icon indicating copy to clipboard operation
ydb copied to clipboard

Refactor DQ Channels Settings

Open Hor911 opened this issue 1 month ago • 18 comments

For easy reuse (between input and output channels + prepare for new channels):

  1. Args/settings are grouped into single struct
  2. More generic Bind replaces UpdateSettings
  3. Small cleanup in stats hierarchy

Hor911 avatar Dec 11 '25 17:12 Hor911

Run Extra Tests

Run additional tests for this PR. You can customize:

  • Test Size: small, medium, large (default: all)
  • Test Targets: any directory path (default: ydb/)
  • Sanitizers: ASAN, MSAN, TSAN
  • Coredumps: enable for debugging (default: off)
  • Additional args: custom ya make arguments

▶  Run tests

ydbot avatar Dec 11 '25 17:12 ydbot

:white_circle: 2025-12-11 17:12:13 UTC Pre-commit check linux-x86_64-relwithdebinfo for cc18838c4e439496c5bd47c53bed7f1550ee2030 has started. :white_circle: 2025-12-11 17:12:37 UTC Artifacts will be uploaded here :white_circle: 2025-12-11 17:19:00 UTC ya make is running... :red_circle: 2025-12-11 17:22:23 UTC Build failed, see the logs. Also see fail summary

github-actions[bot] avatar Dec 11 '25 17:12 github-actions[bot]

:white_circle: 2025-12-11 17:12:38 UTC Pre-commit check linux-x86_64-release-asan for cc18838c4e439496c5bd47c53bed7f1550ee2030 has started. :white_circle: 2025-12-11 17:12:44 UTC Artifacts will be uploaded here :white_circle: 2025-12-11 17:14:02 UTC ya make is running... :red_circle: 2025-12-11 17:20:22 UTC Build failed, see the logs. Also see fail summary

github-actions[bot] avatar Dec 11 '25 17:12 github-actions[bot]

:green_circle: 2025-12-12 01:51:47 UTC The validation of the Pull Request description is successful.

github-actions[bot] avatar Dec 11 '25 17:12 github-actions[bot]

:white_circle: 2025-12-11 20:41:32 UTC Pre-commit check linux-x86_64-release-asan for 04102cc3fe832afb5be2a96d3cecfe8ba169bae2 has started. :white_circle: 2025-12-11 20:41:49 UTC Artifacts will be uploaded here :white_circle: 2025-12-11 20:43:55 UTC ya make is running... :red_circle: 2025-12-11 20:47:20 UTC Build failed, see the logs. Also see fail summary

github-actions[bot] avatar Dec 11 '25 20:12 github-actions[bot]

:white_circle: 2025-12-11 20:41:36 UTC Pre-commit check linux-x86_64-relwithdebinfo for 04102cc3fe832afb5be2a96d3cecfe8ba169bae2 has started. :white_circle: 2025-12-11 20:41:53 UTC Artifacts will be uploaded here :white_circle: 2025-12-11 20:44:00 UTC ya make is running... :red_circle: 2025-12-11 20:47:35 UTC Build failed, see the logs. Also see fail summary

github-actions[bot] avatar Dec 11 '25 20:12 github-actions[bot]

:white_circle: 2025-12-11 21:55:51 UTC Pre-commit check linux-x86_64-release-asan for cbf9b02c1b6e23b27028f1d285adab07877db2d0 has started. :white_circle: 2025-12-11 21:56:09 UTC Artifacts will be uploaded here :white_circle: 2025-12-11 21:58:13 UTC ya make is running... :yellow_circle: 2025-12-11 23:01:47 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12446 12354 0 76 7 9

:green_circle: 2025-12-11 23:01:56 UTC Build successful. :green_circle: 2025-12-11 23:02:26 UTC ydbd size 3.9 GiB changed* by +4.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: f06dcf57453fa115655a6feabc683324cafed684 merge: cbf9b02c1b6e23b27028f1d285adab07877db2d0 diff diff %
ydbd size 4 133 996 120 Bytes 4 134 000 752 Bytes +4.5 KiB +0.000%
ydbd stripped size 1 534 459 992 Bytes 1 534 462 744 Bytes +2.7 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

github-actions[bot] avatar Dec 11 '25 21:12 github-actions[bot]

:white_circle: 2025-12-11 21:56:46 UTC Pre-commit check linux-x86_64-relwithdebinfo for cbf9b02c1b6e23b27028f1d285adab07877db2d0 has started. :white_circle: 2025-12-11 21:57:04 UTC Artifacts will be uploaded here :white_circle: 2025-12-11 21:59:14 UTC ya make is running... :yellow_circle: 2025-12-11 23:44:41 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
40610 37664 0 9 2908 29

:white_circle: 2025-12-11 23:44:54 UTC ya make is running... (failed tests rerun, try 2) :green_circle: 2025-12-12 00:00:16 UTC Tests successful.

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
63 (only retried tests) 48 0 0 0 15

:green_circle: 2025-12-12 00:00:22 UTC Build successful. :green_circle: 2025-12-12 00:00:47 UTC ydbd size 2.3 GiB changed* by +1.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: f06dcf57453fa115655a6feabc683324cafed684 merge: cbf9b02c1b6e23b27028f1d285adab07877db2d0 diff diff %
ydbd size 2 468 643 864 Bytes 2 468 645 248 Bytes +1.4 KiB +0.000%
ydbd stripped size 525 324 480 Bytes 525 324 928 Bytes +448 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

github-actions[bot] avatar Dec 11 '25 21:12 github-actions[bot]

:white_circle: 2025-12-12 00:40:31 UTC Pre-commit check linux-x86_64-release-asan for ba0b812976b062cb443acb4d60a4357a1c4cedf1 has started. :white_circle: 2025-12-12 00:41:11 UTC Artifacts will be uploaded here :white_circle: 2025-12-12 00:43:10 UTC ya make is running... :black_circle: 2025-12-12 01:10:12 UTC Check cancelled

github-actions[bot] avatar Dec 12 '25 00:12 github-actions[bot]

:white_circle: 2025-12-12 00:45:19 UTC Pre-commit check linux-x86_64-relwithdebinfo for ba0b812976b062cb443acb4d60a4357a1c4cedf1 has started. :white_circle: 2025-12-12 00:45:36 UTC Artifacts will be uploaded here :white_circle: 2025-12-12 00:47:46 UTC ya make is running... :black_circle: 2025-12-12 01:10:09 UTC Check cancelled

github-actions[bot] avatar Dec 12 '25 00:12 github-actions[bot]

:white_circle: 2025-12-12 01:13:08 UTC Pre-commit check linux-x86_64-relwithdebinfo for 104a3c9c173e102232807864a66a8f0cacaf1b27 has started. :white_circle: 2025-12-12 01:13:47 UTC Artifacts will be uploaded here :white_circle: 2025-12-12 01:15:43 UTC ya make is running... :red_circle: 2025-12-12 01:22:29 UTC Build failed, see the logs. Also see fail summary

github-actions[bot] avatar Dec 12 '25 01:12 github-actions[bot]

:white_circle: 2025-12-12 01:17:24 UTC Pre-commit check linux-x86_64-release-asan for 104a3c9c173e102232807864a66a8f0cacaf1b27 has started. :white_circle: 2025-12-12 01:17:42 UTC Artifacts will be uploaded here :white_circle: 2025-12-12 01:19:55 UTC ya make is running... :red_circle: 2025-12-12 01:26:37 UTC Build failed, see the logs. Also see fail summary

github-actions[bot] avatar Dec 12 '25 01:12 github-actions[bot]

:white_circle: 2025-12-12 01:40:48 UTC Pre-commit check linux-x86_64-relwithdebinfo for 0474b6b142649d84a12087d6e680d2c788d41ebf has started. :white_circle: 2025-12-12 01:41:15 UTC Artifacts will be uploaded here :black_circle: 2025-12-12 01:42:37 UTC Check cancelled

github-actions[bot] avatar Dec 12 '25 01:12 github-actions[bot]

:white_circle: 2025-12-12 01:42:05 UTC Pre-commit check linux-x86_64-release-asan for 0474b6b142649d84a12087d6e680d2c788d41ebf has started. :black_circle: 2025-12-12 01:42:26 UTC Check cancelled

github-actions[bot] avatar Dec 12 '25 01:12 github-actions[bot]

:white_circle: 2025-12-12 01:43:54 UTC Pre-commit check linux-x86_64-release-asan for 7daa7fb1779627dbd1dd4f1eaa3139eed7ac3b1d has started. :white_circle: 2025-12-12 01:43:57 UTC Artifacts will be uploaded here :white_circle: 2025-12-12 01:46:04 UTC ya make is running... :red_circle: 2025-12-12 01:50:31 UTC Build failed, see the logs. Also see fail summary

github-actions[bot] avatar Dec 12 '25 01:12 github-actions[bot]

:white_circle: 2025-12-12 01:46:43 UTC Pre-commit check linux-x86_64-relwithdebinfo for 7daa7fb1779627dbd1dd4f1eaa3139eed7ac3b1d has started. :white_circle: 2025-12-12 01:47:01 UTC Artifacts will be uploaded here :white_circle: 2025-12-12 01:49:10 UTC ya make is running... :red_circle: 2025-12-12 01:57:01 UTC Build failed, see the logs. Also see fail summary

github-actions[bot] avatar Dec 12 '25 01:12 github-actions[bot]

:white_circle: 2025-12-12 02:01:09 UTC Pre-commit check linux-x86_64-release-asan for 548c3467950f44cca83c3039df67cbd8af1cd3ac has started. :white_circle: 2025-12-12 02:01:51 UTC Artifacts will be uploaded here :white_circle: 2025-12-12 02:03:40 UTC ya make is running... :yellow_circle: 2025-12-12 03:22:10 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12446 12372 0 54 7 13

:green_circle: 2025-12-12 03:22:18 UTC Build successful. :green_circle: 2025-12-12 03:22:50 UTC ydbd size 3.8 GiB changed* by -135.2 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: f06dcf57453fa115655a6feabc683324cafed684 merge: 548c3467950f44cca83c3039df67cbd8af1cd3ac diff diff %
ydbd size 4 133 996 120 Bytes 4 133 857 696 Bytes -135.2 KiB -0.003%
ydbd stripped size 1 534 459 992 Bytes 1 534 404 344 Bytes -54.3 KiB -0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

github-actions[bot] avatar Dec 12 '25 02:12 github-actions[bot]

:white_circle: 2025-12-12 02:03:00 UTC Pre-commit check linux-x86_64-relwithdebinfo for 548c3467950f44cca83c3039df67cbd8af1cd3ac has started. :white_circle: 2025-12-12 02:03:18 UTC Artifacts will be uploaded here :white_circle: 2025-12-12 02:05:25 UTC ya make is running... :yellow_circle: 2025-12-12 03:53:10 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
40610 37669 0 8 2903 30

:white_circle: 2025-12-12 03:53:23 UTC ya make is running... (failed tests rerun, try 2) :green_circle: 2025-12-12 04:05:59 UTC Tests successful.

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
62 (only retried tests) 49 0 0 0 13

:green_circle: 2025-12-12 04:06:06 UTC Build successful. :green_circle: 2025-12-12 04:06:28 UTC ydbd size 2.3 GiB changed* by -94.6 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: f06dcf57453fa115655a6feabc683324cafed684 merge: 548c3467950f44cca83c3039df67cbd8af1cd3ac diff diff %
ydbd size 2 468 643 864 Bytes 2 468 546 976 Bytes -94.6 KiB -0.004%
ydbd stripped size 525 324 480 Bytes 525 306 112 Bytes -17.9 KiB -0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

github-actions[bot] avatar Dec 12 '25 02:12 github-actions[bot]

Backport

To backport this PR, click the button next to the target branch and then click "Run workflow" in the Run Actions UI.

Branch Run
stable-25-2, stable-25-2-1, stable-25-3, stable-25-3-1 ▶  Backport
stable-25-3, stable-25-3-1 ▶  Backport
stable-25-3 ▶  Backport

▶  Backport manual

ydbot avatar Dec 15 '25 09:12 ydbot