ydb-python-sdk icon indicating copy to clipboard operation
ydb-python-sdk copied to clipboard

getting index type

Open Bobako opened this issue 1 year ago • 3 comments

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

  • [ ] Bugfix
  • [x] Feature
  • [ ] Code style update (formatting, renaming)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] Documentation content changes
  • [ ] Other (please describe):

What is the current behavior?

Метод session.describe_table возвращает в том числе объекты, описывающие индексы таблицы - TableIndex. Этот объект не содержит информации о типе индекса (синхронный или асинхронный), хотя эта информация есть в protobuf сообщении, на основе которого формируется объект.

Issue Number: #351

What is the new behavior?

TableIndex содержать поле type - enum, описывающий тип индекса.

Bobako avatar Sep 15 '23 14:09 Bobako

Привет! Спасибо за патч. Можешь, пожалуйста, ещё тестом это покрыть?)

Valeria1235 avatar Oct 01 '23 12:10 Valeria1235

@Valeria1235, Hi! I tried to use the same approach, but I get nither global_async_index nor global_index from the describe_table, it seems like the server doesn't set this "oneof" field at all. Could you check it, please

LuckySting avatar Apr 04 '24 17:04 LuckySting

@Valeria1235, Hi! I tried to use the same approach, but I get nither global_async_index nor global_index from the describe_table, it seems like the server doesn't set this "oneof" field at all. Could you check it, please

Hi! I was just only reviewed this patch and as you can see there are no one tests cases. So perhaps it's no longer working or relevant.

Valeria1235 avatar Apr 07 '24 01:04 Valeria1235