ydb-go-sdk icon indicating copy to clipboard operation
ydb-go-sdk copied to clipboard

bug: StatusIds_SESSION_EXPIRED is non retriable

Open rekby opened this issue 1 year ago • 2 comments

Bug Report

YDB GO SDK version: 3.53.4

Current behavior: SessionExpired is non retriable error

Expected behavior: SessionExpired is retriable error (for example topic reader must reconnect on the error)

https://github.com/ydb-platform/ydb-go-sdk/blob/899fac3391850e6329ea3fdf991901c877aa3310/retry/errors_data_test.go#L411-L411

rekby avatar Oct 20 '23 11:10 rekby

@rekby @asmyasnikov Hello. I'm a random person. I would like to periodically try to solve some issues of this repository.

I downloaded the repository locally, created a branch, solved the current issue and tried to create remote branch but got an access error: ERROR: Permission to ydb-platform/ydb-go-sdk.git denied to v1tbrah

Please tell me if I can try to solve some issues and if I can, what do I need to do to be able to create branches and PRs?

v1tbrah avatar Dec 30 '23 19:12 v1tbrah

Hello, @v1tbrah thanks for solve the issue!

Sorry for late response.

For create PR:

  1. Fork repository to your own account
  2. Push your changes to branch in your account
  3. You will see create PR button in your repository

Describe create pr in details: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request

rekby avatar Jan 24 '24 10:01 rekby