ydb-go-sdk icon indicating copy to clipboard operation
ydb-go-sdk copied to clipboard

feat: remove discovery events properly

Open pelageech opened this issue 1 year ago • 0 comments

Feature Request

Describe the Feature Request Hi! In https://github.com/ydb-platform/ydb-go-sdk/issues/1390 I wanted to descibe the problem with infinite discovery events. They litter our traces, and I suppose they slow down our trace search.

In other to remove discovery events completely from traces you need to provide tracing details with such a bit mask:

trace.DetailsAll^trace.DriverRepeaterEvents^trace.DiscoveryEvents^trace.DriverBalancerEvents^trace.DriverConnEvents

Firstly, this is too complicated since I need 4 flags to remove 4 spans spawning infinitely. Снимок экрана 2024-08-08 в 13 18 24 I would like to remove them in one xor.

Secondly, ^trace.DriverConnEvents leads to the loss of spans in other parts. I would like to remove (*conn).Invoke spans only for discovery events but to leave them in query events and so on.

Describe Preferred Solution So, one flag to remove discovery events instead of four and splitting (*conn).Invoke traces into discovery and non-discovery.

Describe Alternatives

Related Code

Additional Context

If the feature request is approved, would you be willing to submit a PR? No

pelageech avatar Aug 08 '24 06:08 pelageech