ydb-go-sdk icon indicating copy to clipboard operation
ydb-go-sdk copied to clipboard

* Added `table/options.WithQueryService()` option for redirect `table.Session.Execute` call to `query.Execute`

Open asmyasnikov opened this issue 10 months ago • 5 comments

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

  • [ ] Bugfix
  • [x] Feature
  • [ ] Code style update (formatting, renaming)
  • [x] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] Documentation content changes
  • [ ] Other (please describe):

What is the current behavior?

Issue Number: #1197

What is the new behavior?

Other information

asmyasnikov avatar Apr 17 '24 14:04 asmyasnikov

github.com/ydb-platform/ydb-go-sdk/v3/balancers

incompatible changes

Endpoint.NodeID: changed from func() uint32 to func() int64

github.com/ydb-platform/ydb-go-sdk/v3/query

incompatible changes

WithCallOptions: changed from func(...google.golang.org/grpc.CallOption) github.com/ydb-platform/ydb-go-sdk/v3/internal/query/options.CallOptions to func(...google.golang.org/grpc.CallOption) github.com/ydb-platform/ydb-go-sdk/v3/internal/query/options.GrpcOpts

github.com/ydb-platform/ydb-go-sdk/v3/table

incompatible changes

SessionInfo.NodeID: changed from func() uint32 to func() int64

github.com/ydb-platform/ydb-go-sdk/v3/table/options

incompatible changes

github.com/ydb-platform/ydb-go-sdk/v3/internal/query/options.ExecuteOption.ApplyExecuteOption: added

compatible changes

ExecuteDataQueryDesc.WithQueryService: added WithQueryService: added withCallOptions.ApplyExecuteOption: added

github.com/ydb-platform/ydb-go-sdk/v3/testutil

incompatible changes

(*balancerStub).HasNode: changed from func(uint32) bool to func(int64) bool

github.com/ydb-platform/ydb-go-sdk/v3/trace

incompatible changes

EndpointInfo.NodeID: changed from func() uint32 to func() int64 QueryOnTxExecute: changed from func(*Query, *context.Context, call, querySessionInfo, queryTransactionInfo, string) func(error) to func(*Query, *context.Context, call, queryTransactionInfo, string) func(error) QueryTxExecuteStartInfo.Session: removed tableSessionInfo.NodeID: changed from func() uint32 to func() int64

summary

Base version: v3.65.4-0.20240421132159-929301659f96 (master) Cannot suggest a release version. Can only suggest a release version when compared against the most recent version of this major: v3.65.3.

github-actions[bot] avatar Apr 17 '24 14:04 github-actions[bot]

:volcano: Here are results of SLO test for Go SDK xorm:

Grafana Dashboard

SLO-xorm

github-actions[bot] avatar Apr 17 '24 14:04 github-actions[bot]

:volcano: Here are results of SLO test for Go SDK database/sql:

Grafana Dashboard

SLO-database-sql

github-actions[bot] avatar Apr 17 '24 14:04 github-actions[bot]

:volcano: Here are results of SLO test for Native ydb-go-sdk/v3 over table-service:

Grafana Dashboard

SLO-native-table

github-actions[bot] avatar Apr 17 '24 14:04 github-actions[bot]

:volcano: Here are results of SLO test for Go SDK gorm:

Grafana Dashboard

SLO-gorm

github-actions[bot] avatar Apr 17 '24 14:04 github-actions[bot]