ydb-go-sdk icon indicating copy to clipboard operation
ydb-go-sdk copied to clipboard

enable forcetypeassert linter

Open korovindenis opened this issue 10 months ago • 4 comments

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

  • [ ] Bugfix
  • [ ] Feature
  • [ x] Code style update (formatting, renaming)
  • [ x] Refactoring (no functional changes, no api changes)
  • [ x] Build related changes
  • [ ] Documentation content changes
  • [ ] Other (please describe):

What is the current behavior?

Issue Number: #933

What is the new behavior?

Other information

korovindenis avatar Apr 14 '24 10:04 korovindenis

Codecov Report

Attention: Patch coverage is 32.63889% with 97 lines in your changes are missing coverage. Please review.

Project coverage is 41.04%. Comparing base (b7a9b51) to head (5a238a1). Report is 79 commits behind head on master.

Files Patch % Lines
internal/value/nullable.go 50.00% 11 Missing and 11 partials :warning:
internal/table/client.go 33.33% 5 Missing and 5 partials :warning:
internal/types/types.go 0.00% 10 Missing :warning:
internal/cmd/gtrace/writer.go 0.00% 9 Missing :warning:
log/field.go 52.63% 4 Missing and 5 partials :warning:
internal/value/value.go 50.00% 3 Missing and 3 partials :warning:
internal/conn/conn.go 0.00% 4 Missing :warning:
internal/table/transaction.go 0.00% 4 Missing :warning:
internal/xcontext/local_dc.go 0.00% 4 Missing :warning:
internal/xsql/rows.go 0.00% 4 Missing :warning:
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1195      +/-   ##
==========================================
+ Coverage   40.80%   41.04%   +0.24%     
==========================================
  Files         309      310       +1     
  Lines       32747    33111     +364     
==========================================
+ Hits        13361    13592     +231     
- Misses      18959    19059     +100     
- Partials      427      460      +33     
Flag Coverage Δ
go-1.21.x 43.24% <34.35%> (+0.31%) :arrow_up:
go-1.22.x 41.04% <32.63%> (+0.24%) :arrow_up:
macOS ?
ubuntu 40.50% <32.62%> (+0.20%) :arrow_up:
unit 41.04% <32.63%> (+0.24%) :arrow_up:
windows 41.03% <32.63%> (+0.24%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Apr 14 '24 10:04 codecov-commenter

@rekby @asmyasnikov please, review

korovindenis avatar Apr 17 '24 08:04 korovindenis

Can you exclude forcetypeassert linter for all test files through exclude-rules in .golangci.yml? Your changes cannot add of understanding for tests and type casts in tests not required because if some cast failed - test will failed

asmyasnikov avatar Apr 26 '24 15:04 asmyasnikov

Can you exclude forcetypeassert linter for all test files through exclude-rules in .golangci.yml? Your changes cannot add of understanding for tests and type casts in tests not required because if some cast failed - test will failed

@asmyasnikov Ok. I have made changes

korovindenis avatar Apr 26 '24 17:04 korovindenis