I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

Mar 29 '24 16:03 asmyasnikov

github.com/ydb-platform/ydb-go-sdk/v3/balancers

incompatible changes

Endpoint.LocalDC: removed PreferWithFallback: changed from func(*github.com/ydb-platform/ydb-go-sdk/v3/internal/balancer/config.Config, func(endpoint Endpoint) bool) *github.com/ydb-platform/ydb-go-sdk/v3/internal/balancer/config.Config to func(*github.com/ydb-platform/ydb-go-sdk/v3/internal/balancer/config.Config, func(endpoint github.com/ydb-platform/ydb-go-sdk/v3/internal/conn.Info) bool) *github.com/ydb-platform/ydb-go-sdk/v3/internal/balancer/config.Config

github.com/ydb-platform/ydb-go-sdk/v3/discovery

incompatible changes

Client.Discover: changed from func(context.Context) ([]github.com/ydb-platform/ydb-go-sdk/v3/internal/endpoint.Endpoint, error) to func(context.Context) ([]github.com/ydb-platform/ydb-go-sdk/v3/internal/endpoint.Info, error)

github.com/ydb-platform/ydb-go-sdk/v3/trace

incompatible changes

ConnState.Code: removed ConnState.IsValid: removed Driver.OnConnAllow: removed DriverConnAllowDoneInfo: removed DriverConnAllowStartInfo: removed DriverOnConnAllow: removed EndpointInfo.LocalDC: removed

compatible changes

Driver.OnBalancerGetConn: added Driver.OnBalancerMarkConnAsBad: added Driver.OnConnUnban: added Driver.OnPoolAttach: added Driver.OnPoolDetach: added DriverBalancerGetConnDoneInfo: added DriverBalancerGetConnStartInfo: added DriverBalancerMarkConnAsBadDoneInfo: added DriverBalancerMarkConnAsBadStartInfo: added DriverConnPoolAttachDoneInfo: added DriverConnPoolAttachStartInfo: added DriverConnPoolDetachDoneInfo: added DriverConnPoolDetachStartInfo: added DriverConnUnbanDoneInfo: added DriverConnUnbanStartInfo: added DriverOnBalancerGetConn: added DriverOnBalancerMarkConnAsBad: added DriverOnConnUnban: added DriverOnPoolAttach: added DriverOnPoolDetach: added

summary

Base version: v3.64.1-0.20240410130004-d38f4eca0386 (master) Cannot suggest a release version. Can only suggest a release version when compared against the most recent version of this major: v3.64.0.

Mar 29 '24 16:03 github-actions[bot]

Codecov Report

Attention: Patch coverage is 35.32110% with 423 lines in your changes are missing coverage. Please review.

Project coverage is 39.97%. Comparing base (a0abd92) to head (cae12e7). Report is 6 commits behind head on master.

Files	Patch %	Lines
internal/conn/conn.go	0.00%	121 Missing :warning:
internal/conn/grpc_client_stream.go	0.00%	80 Missing :warning:
internal/balancer/balancer.go	23.95%	70 Missing and 3 partials :warning:
internal/conn/cc_guard.go	0.00%	47 Missing :warning:
internal/balancer/connections.go	75.40%	29 Missing and 1 partial :warning:
internal/conn/pool.go	0.00%	26 Missing :warning:
internal/conn/last_usage_guard.go	50.00%	13 Missing :warning:
internal/mock/endpoint.go	35.00%	13 Missing :warning:
internal/query/result_set.go	85.71%	3 Missing and 1 partial :warning:
internal/conn/in_use_quard.go	85.71%	2 Missing and 1 partial :warning:
... and 7 more

Additional details and impacted files

@@             Coverage Diff             @@
##           master    #1174       +/-   ##
===========================================
- Coverage   68.23%   39.97%   -28.26%     
===========================================
  Files         307      310        +3     
  Lines       32017    32199      +182     
===========================================
- Hits        21847    12873     -8974     
- Misses       9218    18905     +9687     
+ Partials      952      421      -531

Flag	Coverage Δ
	`?`
go-1.21.x	`41.89% <34.08%> (-28.46%)`	:arrow_down:
go-1.22.x	`39.97% <35.32%> (-27.77%)`	:arrow_down:
integration	`?`
macOS	`39.93% <35.32%> (+0.76%)`	:arrow_up:
ubuntu	`39.93% <35.32%> (+0.75%)`	:arrow_up:
unit	`39.97% <35.32%> (+0.73%)`	:arrow_up:
windows	`39.97% <35.32%> (+0.79%)`	:arrow_up:
ydb-23.3	`?`
ydb-24.1	`?`