ydb-go-sdk icon indicating copy to clipboard operation
ydb-go-sdk copied to clipboard

bug: rollback breaking changes from v3.58.1

Open asmyasnikov opened this issue 1 year ago • 0 comments

Bad commit: https://github.com/ydb-platform/ydb-go-sdk/commit/3d565003e3f8dc4ced5b2490701b203bc50f7a96

Breaking changes:

github.com/ydb-platform/ydb-go-sdk/v3

incompatible changes

WithSessionPoolKeepAliveMinSize: removed WithSessionPoolKeepAliveTimeout: removed

github.com/ydb-platform/ydb-go-sdk/v3/trace

incompatible changes

Coordination: old is comparable, new is not DatabaseSQLOnTxExec: changed from func(*DatabaseSQL, *context.Context, call, context.Context, tableTransactionInfo, string, bool) func(error) to func(*DatabaseSQL, *context.Context, call, context.Context, tableTransactionInfo, string) func(error) DatabaseSQLOnTxQuery: changed from func(*DatabaseSQL, *context.Context, call, context.Context, tableTransactionInfo, string, bool) func(error) to func(*DatabaseSQL, *context.Context, call, context.Context, tableTransactionInfo, string) func(error) DatabaseSQLTxExecStartInfo.Idempotent: removed DatabaseSQLTxQueryStartInfo.Idempotent: removed Driver.OnBalancerDialEntrypoint: removed Driver.OnConnNewStream: changed from func(DriverConnNewStreamStartInfo) func(DriverConnNewStreamRecvInfo) func(DriverConnNewStreamDoneInfo) to func(DriverConnNewStreamStartInfo) func(DriverConnNewStreamDoneInfo) Driver.OnConnTake: removed Driver.OnNetClose: removed Driver.OnNetDial: removed Driver.OnNetRead: removed Driver.OnNetWrite: removed DriverBalancerUpdateDoneInfo.Error: removed DriverClusterEvents: removed DriverConnNewStreamDoneInfo.Metadata: removed DriverConnNewStreamRecvInfo: removed DriverOnBalancerDialEntrypoint: removed DriverOnBalancerUpdate: changed from func(*Driver, *context.Context, call, bool) func(endpoints []EndpointInfo, added []EndpointInfo, dropped []EndpointInfo, localDC string, _ error) to func(*Driver, *context.Context, call, bool) func(endpoints []EndpointInfo, added []EndpointInfo, dropped []EndpointInfo, localDC string) DriverOnConnNewStream: changed from func(*Driver, *context.Context, call, EndpointInfo, Method) func(error) func(_ error, state ConnState, metadata map[string][]string) to func(*Driver, *context.Context, call, EndpointInfo, Method) func(_ error, state ConnState) DriverOnConnTake: removed DriverOnNetClose: removed DriverOnNetDial: removed DriverOnNetRead: removed DriverOnNetWrite: removed Query.OnDo: changed from func(QueryDoStartInfo) func(info QueryDoIntermediateInfo) func(QueryDoDoneInfo) to func(QueryDoStartInfo) func(QueryDoDoneInfo) Query.OnDoTx: changed from func(QueryDoTxStartInfo) func(info QueryDoTxIntermediateInfo) func(QueryDoTxDoneInfo) to func(QueryDoTxStartInfo) func(QueryDoTxDoneInfo) Query.OnPoolProduce: removed Query.OnPoolSpawn: removed Query.OnPoolWant: removed QueryDoIntermediateInfo: removed QueryDoTxIntermediateInfo: removed QueryExecuteEvents: removed QueryNewDoneInfo.Error: removed QueryOnDo: changed from func(*Query, *context.Context, call) func(error) func(attempts int, _ error) to func(*Query, *context.Context, call) func(attempts int, _ error) QueryOnDoTx: changed from func(*Query, *context.Context, call) func(error) func(attempts int, _ error) to func(*Query, *context.Context, call) func(attempts int, _ error) QueryOnNew: changed from func(*Query, *context.Context, call) func(error) to func(*Query, *context.Context, call) func() QueryOnPoolNew: changed from func(*Query, *context.Context, call, int, int, int) func(_ error, minSize int, maxSize int, producersCount int) to func(*Query, *context.Context, call) func(limit int) QueryOnPoolProduce: removed QueryOnPoolSpawn: removed QueryOnPoolWant: removed QueryPoolNewDoneInfo.Error: removed QueryPoolNewDoneInfo.MaxSize: removed QueryPoolNewDoneInfo.MinSize: removed QueryPoolNewDoneInfo.ProducersCount: removed QueryPoolNewStartInfo.MaxSize: removed QueryPoolNewStartInfo.MinSize: removed QueryPoolNewStartInfo.ProducersCount: removed QueryPoolProduceDoneInfo: removed QueryPoolProduceStartInfo: removed QueryPoolSpawnDoneInfo: removed QueryPoolSpawnStartInfo: removed QueryPoolWantDoneInfo: removed QueryPoolWantStartInfo: removed Retry.OnRetry: changed from func(RetryLoopStartInfo) func(RetryLoopIntermediateInfo) func(RetryLoopDoneInfo) to func(RetryLoopStartInfo) func(RetryLoopDoneInfo) RetryLoopIntermediateInfo: removed RetryLoopStartInfo.ID: removed RetryOnRetry: changed from func(*Retry, *context.Context, string, call, string, bool, bool) func(error) func(attempts int, _ error) to func(*Retry, *context.Context, call, string, bool, bool) func(attempts int, _ error) Table.OnCreateSession: changed from func(TableCreateSessionStartInfo) func(info TableCreateSessionIntermediateInfo) func(TableCreateSessionDoneInfo) to func(TableCreateSessionStartInfo) func(TableCreateSessionDoneInfo) Table.OnDo: changed from func(TableDoStartInfo) func(info TableDoIntermediateInfo) func(TableDoDoneInfo) to func(TableDoStartInfo) func(TableDoDoneInfo) Table.OnDoTx: changed from func(TableDoTxStartInfo) func(info TableDoTxIntermediateInfo) func(TableDoTxDoneInfo) to func(TableDoTxStartInfo) func(TableDoTxDoneInfo) Table.OnPoolSessionClose: removed Table.OnPoolSessionNew: removed Table.OnSessionQueryStreamExecute: changed from func(TableSessionQueryStreamExecuteStartInfo) func(TableSessionQueryStreamExecuteIntermediateInfo) func(TableSessionQueryStreamExecuteDoneInfo) to func(TableSessionQueryStreamExecuteStartInfo) func(TableSessionQueryStreamExecuteDoneInfo) Table.OnSessionQueryStreamRead: changed from func(TableSessionQueryStreamReadStartInfo) func(TableSessionQueryStreamReadIntermediateInfo) func(TableSessionQueryStreamReadDoneInfo) to func(TableSessionQueryStreamReadStartInfo) func(TableSessionQueryStreamReadDoneInfo) Table.OnSessionTransactionBegin: removed Table.OnSessionTransactionCommit: removed Table.OnSessionTransactionExecute: removed Table.OnSessionTransactionExecuteStatement: removed Table.OnSessionTransactionRollback: removed TableCreateSessionIntermediateInfo: removed TableDoIntermediateInfo: removed TableDoStartInfo.ID: removed TableDoTxIntermediateInfo: removed TableDoTxStartInfo.ID: removed TableInitDoneInfo.Error: removed TableOnCreateSession: changed from func(*Table, *context.Context, call) func(error) func(session tableSessionInfo, attempts int, _ error) to func(*Table, *context.Context, call) func(session tableSessionInfo, attempts int, _ error) TableOnDo: changed from func(*Table, *context.Context, call, string, string, bool, bool) func(error) func(attempts int, _ error) to func(*Table, *context.Context, call, string, bool, bool) func(attempts int, _ error) TableOnDoTx: changed from func(*Table, *context.Context, call, string, string, bool, bool) func(error) func(attempts int, _ error) to func(*Table, *context.Context, call, string, bool, bool) func(attempts int, _ error) TableOnInit: changed from func(*Table, *context.Context, call) func(limit int, _ error) to func(*Table, *context.Context, call) func(limit int) TableOnPoolSessionClose: removed TableOnPoolSessionNew: removed TableOnSessionQueryStreamExecute: changed from func(*Table, *context.Context, call, tableSessionInfo, tableDataQuery, tableQueryParameters) func(error) func(error) to func(*Table, *context.Context, call, tableSessionInfo, tableDataQuery, tableQueryParameters) func(error) TableOnSessionQueryStreamRead: changed from func(*Table, *context.Context, call, tableSessionInfo) func(error) func(error) to func(*Table, *context.Context, call, tableSessionInfo) func(error) TableOnSessionTransactionBegin: removed TableOnSessionTransactionCommit: removed TableOnSessionTransactionExecute: removed TableOnSessionTransactionExecuteStatement: removed TableOnSessionTransactionRollback: removed TableSessionQueryStreamExecuteIntermediateInfo: removed TableSessionQueryStreamReadIntermediateInfo: removed TableSessionTransactionBeginDoneInfo: removed TableSessionTransactionBeginStartInfo: removed TableSessionTransactionCommitDoneInfo: removed TableSessionTransactionCommitStartInfo: removed TableSessionTransactionRollbackDoneInfo: removed TableSessionTransactionRollbackStartInfo: removed

asmyasnikov avatar Mar 29 '24 08:03 asmyasnikov