ydb-go-sdk icon indicating copy to clipboard operation
ydb-go-sdk copied to clipboard

* Refactored coordination traces

Open asmyasnikov opened this issue 11 months ago • 6 comments

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

  • [ ] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting, renaming)
  • [x] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] Documentation content changes
  • [ ] Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

asmyasnikov avatar Mar 27 '24 07:03 asmyasnikov

github.com/ydb-platform/ydb-go-sdk/v3/trace

incompatible changes

Coordination.OnStreamNew: removed CoordinationOnStreamNew: removed CoordinationStreamNewDoneInfo: removed CoordinationStreamNewStartInfo: removed

compatible changes

Coordination.OnNewSessionClient: added CoordinationNewSessionClientDoneInfo: added CoordinationNewSessionClientStartInfo: added CoordinationOnNewSessionClient: added

summary

Base version: v3.61.3-0.20240327070050-a0abd92e2889 (master) Cannot suggest a release version. Can only suggest a release version when compared against the most recent version of this major: v3.61.2.

github-actions[bot] avatar Mar 27 '24 07:03 github-actions[bot]

Codecov Report

Attention: Patch coverage is 93.61702% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 68.03%. Comparing base (a0abd92) to head (f28eb5f).

Files Patch % Lines
internal/coordination/session.go 93.47% 3 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1168      +/-   ##
==========================================
- Coverage   68.23%   68.03%   -0.20%     
==========================================
  Files         307      307              
  Lines       32017    32055      +38     
==========================================
- Hits        21847    21810      -37     
- Misses       9218     9290      +72     
- Partials      952      955       +3     
Flag Coverage Δ
53.01% <31.91%> (-0.53%) :arrow_down:
go-1.21.x 70.15% <93.61%> (-0.21%) :arrow_down:
go-1.22.x 68.02% <93.61%> (+0.27%) :arrow_up:
integration 53.01% <31.91%> (-0.53%) :arrow_down:
macOS 39.22% <61.70%> (+0.04%) :arrow_up:
ubuntu 39.19% <61.70%> (+0.01%) :arrow_up:
unit 39.27% <61.70%> (+0.02%) :arrow_up:
windows 39.25% <61.70%> (+0.08%) :arrow_up:
ydb-23.3 48.41% <31.91%> (-0.07%) :arrow_down:
ydb-24.1 52.81% <31.91%> (-0.47%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Mar 27 '24 07:03 codecov-commenter

:volcano: Here are results of SLO test for Go SDK gorm:

Grafana Dashboard

SLO-gorm

github-actions[bot] avatar Mar 27 '24 07:03 github-actions[bot]

:volcano: Here are results of SLO test for Go SDK xorm:

Grafana Dashboard

SLO-xorm

github-actions[bot] avatar Mar 27 '24 07:03 github-actions[bot]

:volcano: Here are results of SLO test for Native ydb-go-sdk/v3 over table-service:

Grafana Dashboard

SLO-native-table

github-actions[bot] avatar Mar 27 '24 07:03 github-actions[bot]

:volcano: Here are results of SLO test for Go SDK database/sql:

Grafana Dashboard

SLO-database-sql

github-actions[bot] avatar Mar 27 '24 07:03 github-actions[bot]