ydb-go-sdk icon indicating copy to clipboard operation
ydb-go-sdk copied to clipboard

enabled nonamedreturns linter

Open hrapovd1 opened this issue 1 year ago • 5 comments

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

  • [ ] Bugfix
  • [ ] Feature
  • [x] Code style update (formatting, renaming)
  • [x] Refactoring (no functional changes, no api changes)
  • [x] Build related changes
  • [ ] Documentation content changes
  • [ ] Other (please describe):

What is the current behavior?

Issue Number: #958

What is the new behavior?

Other information

hrapovd1 avatar Feb 05 '24 19:02 hrapovd1

Codecov Report

Attention: Patch coverage is 51.58730% with 732 lines in your changes are missing coverage. Please review.

Project coverage is 65.73%. Comparing base (132dfcc) to head (68e1ee6).

Files Patch % Lines
internal/value/type.go 0.00% 520 Missing :warning:
internal/table/scanner/scan_raw.go 26.38% 53 Missing :warning:
internal/xsql/tx_fake.go 0.00% 37 Missing :warning:
internal/table/scanner/scanner.go 52.38% 24 Missing and 6 partials :warning:
internal/cmd/gtrace/writer.go 0.00% 15 Missing :warning:
internal/xsql/conn.go 84.61% 6 Missing and 6 partials :warning:
internal/scheme/client.go 78.43% 10 Missing and 1 partial :warning:
internal/cmd/gtrace/main.go 0.00% 7 Missing :warning:
internal/allocator/allocator.go 94.05% 6 Missing :warning:
internal/table/session.go 86.36% 6 Missing :warning:
... and 18 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1033      +/-   ##
==========================================
- Coverage   66.78%   65.73%   -1.05%     
==========================================
  Files         285      286       +1     
  Lines       27908    28711     +803     
==========================================
+ Hits        18638    18873     +235     
- Misses       8407     8977     +570     
+ Partials      863      861       -2     
Flag Coverage Δ
53.28% <47.88%> (-0.83%) :arrow_down:
go-1.21.x 67.36% <50.30%> (-1.13%) :arrow_down:
go-1.22.x 65.64% <51.58%> (-1.14%) :arrow_down:
integration 53.28% <47.88%> (-0.83%) :arrow_down:
macOS 37.43% <23.28%> (-0.75%) :arrow_down:
ubuntu 37.46% <23.34%> (-0.70%) :arrow_down:
unit 37.50% <23.34%> (-0.73%) :arrow_down:
windows 37.46% <23.28%> (-0.73%) :arrow_down:
ydb-22.5 50.96% <45.93%> (-0.77%) :arrow_down:
ydb-23.1 50.99% <45.93%> (-0.75%) :arrow_down:
ydb-23.2 50.98% <45.93%> (-0.93%) :arrow_down:
ydb-23.3 51.11% <46.07%> (-0.59%) :arrow_down:
ydb-24.1 53.02% <47.88%> (-0.87%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Feb 27 '24 19:02 codecov-commenter

@hrapovd1 hello. I saw you made few commits for fixes integration tests, but it still broken.

Do you need description how to run the tests at local computer - for faster check fixes and able to run a test with debugger?

rekby avatar Feb 28 '24 03:02 rekby

Hello, @rekby! Thank you for question. Could you please comment my way for tests which I'm using on local PC? I'm testing in that way:

  • create dir: mkdir /tmp/ydb_certs
  • run ydb: docker run --rm -it --name ydb -p 2135:2135 -p 2136:2136 -p 8765:8765 -h localhost -e "YDB_LOCAL_SURVIVE_RESTART=true" -e "YDB_USE_IN_MEMORY_PDISKS=true" -e CI=true -v "/tmp/ydb_certs":"/ydb_certs" cr.yandex/yc/yandex-docker-local-ydb:23.2
  • In the second bash session I'm export env vars:
    GO: 1.21.x
    YDB_VERSION: 22.5
    YDB_CONNECTION_STRING: grpc://localhost:2136/local
    YDB_CONNECTION_STRING_SECURE: grpcs://localhost:2135/local
    YDB_SSL_ROOT_CERTIFICATES_FILE: /tmp/ydb_certs/ca.pem
    YDB_SESSIONS_SHUTDOWN_URLS: http://localhost:8765/actors/kqp_proxy?force_shutdown=all
    HIDE_APPLICATION_OUTPUT: 1
  • And run tests: cd ydb-go-sdk; go clean -testcache; go test -race -tags integration ./tests/integration"

hrapovd1 avatar Feb 28 '24 10:02 hrapovd1

Yesterday I've committed changes in master branch of my fork because integration tests of upstream master branch had got the same errors on my local PC. And I decided that some local problems and tests will be done in CI...

hrapovd1 avatar Feb 28 '24 10:02 hrapovd1

@asmyasnikov , @rekby hello! Could you please check my work and merge if it's OK?

hrapovd1 avatar Mar 05 '24 05:03 hrapovd1