ydb-go-sdk
ydb-go-sdk copied to clipboard
fixed flaky tests
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Pull request type
Fixed flaky tests which use xtest.SpinWaitCondition
Please check the type of change your PR introduces:
- [x] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, renaming)
- [ ] Refactoring (no functional changes, no api changes)
- [x] Build related changes
- [ ] Documentation content changes
- [ ] Other (please describe):
What is the current behavior?
Sometimes tests using xtest.SpinWaitCondition
fails.
Issue Number: #996 #741
It looks like that jobs' server performance degrades sometimes, which causes failed tests. I think, that using greater timeout value will help in such cases.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
c6e45cd
) 68.48% compared to head (47b6cdf
) 68.40%.
Additional details and impacted files
@@ Coverage Diff @@
## master #1029 +/- ##
==========================================
- Coverage 68.48% 68.40% -0.09%
==========================================
Files 252 252
Lines 25155 25155
==========================================
- Hits 17228 17207 -21
- Misses 7069 7086 +17
- Partials 858 862 +4
Flag | Coverage Δ | |
---|---|---|
55.11% <ø> (-0.08%) |
:arrow_down: | |
go-1.20.x | 68.28% <ø> (+<0.01%) |
:arrow_up: |
go-1.21.x | 68.37% <ø> (-0.09%) |
:arrow_down: |
integration | 55.11% <ø> (-0.08%) |
:arrow_down: |
macOS | 38.67% <ø> (+0.01%) |
:arrow_up: |
ubuntu | 38.68% <ø> (ø) |
|
unit | 38.74% <ø> (+<0.01%) |
:arrow_up: |
windows | 38.69% <ø> (-0.03%) |
:arrow_down: |
ydb-22.5 | 54.59% <ø> (-0.24%) |
:arrow_down: |
ydb-23.1 | 54.97% <ø> (+0.03%) |
:arrow_up: |
ydb-23.2 | 54.77% <ø> (-0.04%) |
:arrow_down: |
ydb-23.3 | 54.70% <ø> (-0.29%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.