ydb-go-sdk icon indicating copy to clipboard operation
ydb-go-sdk copied to clipboard

enable ifshort linter

Open ShishkovEM opened this issue 1 year ago • 2 comments

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

  • [ ] Bugfix
  • [ ] Feature
  • [x] Code style update (formatting, renaming)
  • [x] Refactoring (no functional changes, no api changes)
  • [x] Build related changes
  • [ ] Documentation content changes
  • [ ] Other (please describe):

What is the current behavior?

Issue Number: #946

What is the new behavior?

Other information

ShishkovEM avatar Jan 30 '24 22:01 ShishkovEM

Codecov Report

Attention: Patch coverage is 22.58065% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 40.79%. Comparing base (b7a9b51) to head (5f81a80). Report is 160 commits behind head on master.

Files Patch % Lines
internal/table/scanner/scan_raw.go 0.00% 14 Missing :warning:
internal/table/scanner/result.go 0.00% 0 Missing and 2 partials :warning:
internal/table/scanner/scanner.go 0.00% 2 Missing :warning:
internal/conn/conn.go 0.00% 1 Missing :warning:
internal/decimal/decimal.go 75.00% 1 Missing :warning:
internal/query/client.go 0.00% 1 Missing :warning:
...al/topic/topicreaderinternal/stream_reconnector.go 50.00% 0 Missing and 1 partial :warning:
internal/topic/topicwriterinternal/message.go 0.00% 0 Missing and 1 partial :warning:
internal/xsql/tx.go 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1023      +/-   ##
==========================================
- Coverage   40.80%   40.79%   -0.01%     
==========================================
  Files         309      312       +3     
  Lines       32747    33196     +449     
==========================================
+ Hits        13361    13542     +181     
- Misses      18959    19203     +244     
- Partials      427      451      +24     
Flag Coverage Δ
go-1.21.x 42.92% <22.58%> (-0.02%) :arrow_down:
go-1.22.x 40.78% <22.58%> (-0.01%) :arrow_down:
macOS 40.23% <20.00%> (-0.07%) :arrow_down:
ubuntu 40.27% <20.00%> (-0.03%) :arrow_down:
unit 40.79% <22.58%> (-0.01%) :arrow_down:
windows 40.78% <22.58%> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jan 31 '24 06:01 codecov-commenter

По каким-то причинам некоторые issue от ifshort не показывались у меня локально. В последнем коммите исправил те issue, которые были выявлены при автоматической проверке в джобах golangci-lint, golangci-lint-examples и golangci-lint-slo.

ShishkovEM avatar Jan 31 '24 11:01 ShishkovEM