ydata-profiling icon indicating copy to clipboard operation
ydata-profiling copied to clipboard

Published 20 hours ago • verified publisher icon ydataai

feat: refactor var description

Open vorel99 opened this issue 1 year ago • 3 comments

This is my second refactoring pull request. First was #1302 My aim is to replace dictionaries with classes for easier feature developing.

  • new dataclasses for series description and series description hashable
  • add property for common propertyes from dict
  • support old dict like syntax in those classes
  • remove describe_counts and describe_generic (logic moved to classes VarDescription)

vorel99 avatar Sep 14 '23 15:09 vorel99

missing spark refactoring (tbd)

vorel99 avatar Sep 14 '23 18:09 vorel99

Hi @vorel99 ,

Thank you for your contribution! I'll just ask a small change, we don't use the "refactor: ". Please ensure that you use "feat: " instead or any other naming and convention that we are using for the automatic calculation of the package versions.

In what concerns the proposed changes we will be analyzing and validating wether they fit the roadmap for the package.

fabclmnt avatar Sep 19 '23 17:09 fabclmnt

@vorel99 The PR looks great. Whenever you are ready, please, mark it as Ready for review such that we can start the CI/CD. I'll also do some local tests to ensure everything is fine.

aquemy avatar Sep 20 '23 08:09 aquemy