ydata-profiling
ydata-profiling copied to clipboard
docs: updated 179 broken links
yamw
Hi @k3agan,
thank you for the help with the links update!
Hi @k3agan , your commit message is not following the linter format. May I ask you to update it so we can merge your PR?
Hi Fabiana, thanks for letting me know, I am updating it now
On Thu, Mar 16, 2023 at 4:29 PM Fabiana @.***> wrote:
Hi @k3agan https://github.com/k3agan , your commit message is not following the linter format. May I ask you to update it so we can merge your PR?
— Reply to this email directly, view it on GitHub https://github.com/ydataai/ydata-profiling/pull/1281#issuecomment-1472893206, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANOBKLODJDBWGQFESSEKH2LW4OO5JANCNFSM6AAAAAAVV2GECU . You are receiving this because you were mentioned.Message ID: @.***>
Just refreshed my branch, I can do it!
Sorry still new at this 😃
Hi @fabclmnt ,
I've just pushed the new commit that addresses the linting issues you pointed out. Apologies for any confusion my previous commit may have caused, and I appreciate your patience as I continue to learn the ropes. Thank you for your guidance in helping me get this pull request up to par.
I believe the pull request should now be in line with the defined standards. Please let me know if any additional changes are required.
Best regards,
Keagan
Codecov Report
Patch and project coverage have no change.
Comparison is base (
05aaf87) 90.37% compared to head (b0820eb) 90.37%.
:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@ Coverage Diff @@
## develop #1281 +/- ##
========================================
Coverage 90.37% 90.37%
========================================
Files 185 185
Lines 5725 5725
========================================
Hits 5174 5174
Misses 551 551
| Flag | Coverage Δ | |
|---|---|---|
| py3.8-ubuntu-latest-pandas | 90.37% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
This is a learning moment for me 😆
edit:
All fixed.
So apparently both the commit and the pull request need semantic messages.
@k3agan any particular reason to change this link?

(don't worry too much about the commit semantic, we're squashing everything)