ydata-profiling icon indicating copy to clipboard operation
ydata-profiling copied to clipboard

chore(tests): use 'urllib.request' instead of 'requests'

Open stormbeforesunsetbee opened this issue 2 years ago • 3 comments

Following #1177

stormbeforesunsetbee avatar Nov 29 '22 03:11 stormbeforesunsetbee

Codecov Report

Base: 90.46% // Head: 90.46% // No change to project coverage :thumbsup:

Coverage data is based on head (9252208) compared to base (37867a4). Patch coverage: 90.90% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1185   +/-   ##
========================================
  Coverage    90.46%   90.46%           
========================================
  Files          181      181           
  Lines         5514     5514           
========================================
  Hits          4988     4988           
  Misses         526      526           
Flag Coverage Δ
py3.8-ubuntu-latest-pandas 90.46% <90.90%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tests/issues/test_issue377.py 82.60% <50.00%> (ø)
src/pandas_profiling/utils/cache.py 100.00% <100.00%> (ø)
tests/issues/test_issue537.py 94.59% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov-commenter avatar Nov 29 '22 03:11 codecov-commenter

@rivanfebrian123 Thank you so much for your time on this! It's very appreciated.

aquemy avatar Nov 30 '22 08:11 aquemy

Some changes has been merged yesterday and they are not into your branch yet apparently.

Ah... good to know

Could you please rebase from develop?

Actually, it wasn't possible to rebase as there was a merge conflict. So I revert commits in the branch and force-push instead. But don't worry, we're good to go now

stormbeforesunsetbee avatar Nov 30 '22 10:11 stormbeforesunsetbee