Yong Cong Sin

Results 58 comments of Yong Cong Sin

@nashif what else should I do to move this forward?

The CI error is probably unrelated, I have created #72979

Uh.. GitHub automatically removed some reviewers as there's not enough space, but feel free to review

Reran the doc build jobs and now it passed, ping @andyross @dcpleung @nashif

I think it makes sense to introduce a new `SOC_HAS_CUSTOM_RESET` Kconfig, selected by SOCs that need it and probably deprecate `INCLUDE_RESET_VECTOR`, but we can do that at a later time.

> Change looks good, but I wonder @ycsin if we could introduce this incrementally? We have Zephyr use SOF as a submodule, but we also have SOF mainline using Zephyr...

> * add a ifdef on Zephyr version to this PR and include "version.h" if old Zephyr and "zephyr/version.h" if new Zephyr. then CI should be good and we can...

> Aa, this was just merged to main: > > ``` > commit 702399080e94131c124d8c5428e6508e8c8d0bb1 > Author: Fabio Baltieri > Date: Wed Nov 8 10:05:50 2023 +0000 > > Kconfig: drop...

force pushed to add the license identifier to the newly added `Kconfig` file