openxlsx icon indicating copy to clipboard operation
openxlsx copied to clipboard

Cleanup references to drawing and vmlDrawing. If the workbook does no…

Open JanMarvin opened this issue 4 years ago • 3 comments

…t contain these directories, the references may disturb third party software (Excel usually does not bother for some reason). fixes #285

This is fix1 from #231

JanMarvin avatar Nov 20 '21 11:11 JanMarvin

Codecov Report

Merging #301 (8959636) into master (1c0295d) will increase coverage by 0.03%. The diff coverage is 94.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #301      +/-   ##
==========================================
+ Coverage   66.48%   66.51%   +0.03%     
==========================================
  Files          34       34              
  Lines        8939     8950      +11     
==========================================
+ Hits         5943     5953      +10     
- Misses       2996     2997       +1     
Impacted Files Coverage Δ
R/WorkbookClass.R 59.23% <94.44%> (+0.14%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 08de207...8959636. Read the comment docs.

codecov-commenter avatar Nov 20 '21 13:11 codecov-commenter

If a comment is added to a workbook and the workbook is saved:

  1. the xl/drawings/vmlDrawing1.vml is written
  2. the xl/drawings/vmlDrawing1.vml is imported to wb$vml[[1]]
  3. this happens without checking whats in wb$vml[[1]]

This might be dangerous and requires testing!

JanMarvin avatar Nov 20 '21 13:11 JanMarvin

needs unittests as well

JanMarvin avatar Nov 20 '21 14:11 JanMarvin