YouCompleteMe icon indicating copy to clipboard operation
YouCompleteMe copied to clipboard

Update Linux Dependency--Go

Open Eroge-Newton opened this issue 1 year ago • 5 comments

PR Prelude

Please complete these steps and check these boxes (by putting an x inside the brackets) before filing your PR:

  • [x] I have read and understood YCM's CONTRIBUTING document.
  • [x] I have read and understood YCM's CODE_OF_CONDUCT document.
  • [x] I have included tests for the changes in my PR. If not, I have included a rationale for why I haven't.
  • [x] I understand my PR may be closed if it becomes obvious I didn't actually perform all of these steps.

Why this change is necessary and useful

Fixing compilation errors on Linux by updating dependencies (Go)


This change is Reviewable

Eroge-Newton avatar Aug 19 '24 11:08 Eroge-Newton

My markdown editor doesn't seem to handle spaces the same way as the one you use. If there is a difference in display or if it doesn't meet the project's specifications, please fix it.(Line 356, 525, 1410)

Eroge-Newton avatar Aug 19 '24 13:08 Eroge-Newton

Thanks!

:lgtm:

puremourning avatar Aug 19 '24 17:08 puremourning

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.79%. Comparing base (0d85596) to head (27f2052). Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4258      +/-   ##
==========================================
+ Coverage   89.72%   89.79%   +0.06%     
==========================================
  Files          37       37              
  Lines        4780     4780              
==========================================
+ Hits         4289     4292       +3     
+ Misses        491      488       -3     

codecov[bot] avatar Aug 19 '24 17:08 codecov[bot]

Don't we normally tailor the Ubuntu install instructions for the latest LTS? The go there is new enough, so the people running the latest Ubuntu LTS don't need the PPA.

bstaletic avatar Aug 19 '24 18:08 bstaletic

Ubuntu 24.04.1 LTS was scheduled to ship this week but has now been delayed toSeptember in order to address some high profile upgrade bugs. This means that if you have Ubuntu 22.04 lTS previously installed on the system, you will not be notified of the new LTS update at this time.

Don't we normally tailor the Ubuntu install instructions for the latest LTS? The go there is new enough, so the people running the latest Ubuntu LTS don't need the PPA.

If you think this is insignificant, please change the version in docs from 22.04 to 24.04, and update the vim version along with it.

Eroge-Newton avatar Aug 20 '24 00:08 Eroge-Newton

We have updated the docs for the new Ubuntu LTS. I'll close this now. @Eroge-Newton Thanks for the pull request anyway!

bstaletic avatar Sep 12 '24 00:09 bstaletic