tickle icon indicating copy to clipboard operation
tickle copied to clipboard

Making this work for times less than 1 day

Open gampleman opened this issue 8 years ago • 4 comments

every 15 seconds would be pretty excellent if supported.

What would need to be done to get that working?

gampleman avatar Oct 05 '15 14:10 gampleman

Hi @gampleman

To be honest, I'm not sure. Work on this got sidelined for a while for other things. There is updated code on the develop branch, take a look there instead of the master. If you provide a spec for it, that would be the most helpful thing to get started, and then I could give it a go asap.

Regards, iain

yb66 avatar Oct 06 '15 04:10 yb66

Hi @gampleman

I've just pushed some changes to the develop branch that the specs say handle "3 seconds". You can either choose "seconds" or "sec" but not "second", as that clashes with other ordinals. I haven't looked at anything for the other specs you added. Let me know if you find a problem.

Regards iain

yb66 avatar Oct 13 '15 10:10 yb66

Looks ok, but the every other seconds use case doesn't make much sense. Can we not exploit context to disambiguate the ordinal from the unit?

gampleman avatar Oct 13 '15 11:10 gampleman

every other second

every second day

every second

I think that’s going to be a tough ask the way the library is designed right now. I’d love to replace what’s there with a proper parser that could handle things like this more easily, but that’s down the road. I’ll give it a try, but don’t get your hopes up.

Regards, iain

On 13 Oct 2015, at 12:29, Jakub Hampl [email protected] wrote:

Looks ok, but the every other seconds use case doesn't make much sense. Can we not exploit context to disambiguate the ordinal from the unit?

— Reply to this email directly or view it on GitHub.

yb66 avatar Oct 13 '15 16:10 yb66