SDIT icon indicating copy to clipboard operation
SDIT copied to clipboard

What is the correct value?

Open taki0112 opened this issue 5 years ago • 6 comments

In your paper, you use a 800 lambda for the image reconstruction loss. but, in readme, you use a 800 lambda for the latent reconstruction loss.

where should I use 800 ? image_rec ? or latent_rec ?

taki0112 avatar Oct 10 '19 07:10 taki0112

Hi @taki0112 , Thanks. There is a type error. The parametric for latent_rec (noise) is configured to 800, while the image_rec is 10. I will update the project to mention this error

yaxingwang avatar Oct 10 '19 08:10 yaxingwang

I have update it.

yaxingwang avatar Oct 10 '19 08:10 yaxingwang

@yaxingwang I saw your update. Thank you

one more.

  1. I think you should remove #(https://github.com/yaxingwang/SDIT/blob/master/solver.py#L273). What do you think ?
  2. And in your paper, you use 10 lambda for adversarial_loss. but in code, you use 1. I think 1 is correct. right?

taki0112 avatar Oct 10 '19 08:10 taki0112

Thanks. I will update it.

yaxingwang avatar Oct 10 '19 08:10 yaxingwang

if you don't use a noise_loss for the discriminator, then you also remove this. d_loss_noise

taki0112 avatar Oct 10 '19 09:10 taki0112

In fact we try different configures to d_loss_noise, and we use it. I will finally check this configure.

yaxingwang avatar Oct 10 '19 09:10 yaxingwang