Joern Barthel

Results 48 comments of Joern Barthel

Sorry, still on vacation - can it wait until beginning of next month?

This looks like a great contribution! Anything anyone outside of the PR can do to help move it along?

Partially done in 201009e71bce473daf61858fe69990d8e4300975 - now Travis & Appveyor need to go

Awesome PR @ViViDboarder, thanks a lot! Review will be done ~Monday.

Yeah, sorry about that. I'll do the review today / in the afternoon.

Hey @ViViDboarder - are the remaining issues clear? Should we proceed with this PR?

As an alternative: just add the tests and I'll do the minor / cosmetic changes in your PR? Maybe easier?

I can totally live without `SET CODE` if you can substitute it with a `ykman` call. For the test environment that's fine. Spare Yubikey, hm - that's an issue of...

If I understand [this](http://0pointer.de/blog/projects/os-release.html) summary correctly, `/etc/os-release` is systemd-specific which does not apply to CentOS 6.