Jonas Konrad

Results 234 comments of Jonas Konrad
trafficstars

What's the advantage of a new API? You can just block and return a Publishers.just, if you want. It shouldn't cause any issues.

How about you just rewrite the existing clients to block and use Publishers.just, and then for 5.0 we can do the api change. That way we don't need two apis...

While reactive types are still faster, with virtual threads the main disadvantages disappear, so yes we should remove that recommendation. > Using blocking types will block the event loop thread...

I think you are misunderstanding what "blocking the event loop" means. It does not matter *how* you do the blocking, whether the client is annotated with ExecuteOn (which I believe...

Well, what do you want your CSV to look like? Both the list and the object are not straight-forward to map.

JsonAnyGetter/Setter will already not appear in the serialization/deserialization as its own property. The JsonIgnore is not necessary and should not be there

That change did not introduce empty behavior, it added an exception message for decoding failures. What would you like to happen when the body is empty? We can't decode it...

For status codes >=400 we already have exception-on-error-status. For 2xx with empty body, we can't parse the body as json, so there is no sensible default to return. We must...

ah, you want an empty mono? that would indeed be a reasonable value. i was thinking of the blocking case.

Yes it's intentional. PipeliningServerHandler does the release. This is not sufficient information to determine the cause of the leak.