JsonLogic.Net icon indicating copy to clipboard operation
JsonLogic.Net copied to clipboard

Prevent multiple enumeration in GenericArgsSatisfy

Open MaxHayman opened this issue 1 year ago • 0 comments

Doing a property like this I was noticing that the line was being printed twice.

    public uint Number
    {
        get
        {
            Console.WriteLine("Evaluated Number");
            return _testData.Number;
        }
    }

It was being evaluated in the isAllText call and allso in the CheckCriteria call in GenericArgsSatisfy.

Doing a ToList prevents this being evaluated multiple times by preventing multiple enumeration. I plan on having some not as fast logic behind some properties so evaluating these twice would be bad on performance.

This also leads to a ~15% performance increase in my testing.

Before

Method Mean Error StdDev Allocated
Test 946.8 ns 18.60 ns 33.54 ns 1.83 KB

After

Method Mean Error StdDev Allocated
Test 799.0 ns 11.86 ns 11.09 ns 1.68 KB

This also passes all the tests in the test project.

MaxHayman avatar Aug 23 '23 11:08 MaxHayman