graphmod icon indicating copy to clipboard operation
graphmod copied to clipboard

Add support for Cabal 3.6

Open ivb-supercede opened this issue 2 years ago • 4 comments

Cabal 3.6 introduced a breaking change where many FilePaths were replaced with SymbolicPaths - this adds in a compatibility layer for that change.

ivb-supercede avatar Apr 04 '22 12:04 ivb-supercede

Thanks @ivb-supercede ! I don't remember if the 8.2.2 and 8.0.2 builds were failing before, would mind having a look?

yav avatar Apr 06 '22 18:04 yav

Doh! Yep, that's a break I introduced. I'll have to un-nest the definition of the compatibility layer so it's not under Cabal 2.2+

ivb-supercede avatar Apr 07 '22 10:04 ivb-supercede

Some time has passed...

I personally think it's fine to accept the backwards-incompatible change at this point.


I think I ran into this issue right here: https://github.com/jumper149/homepage/actions/runs/3064171134/jobs/4947026997#step:4:1776

jumper149 avatar Sep 15 '22 23:09 jumper149

Whoops, thanks for reminding me about this PR. The backwards-compatibility issue should be fixed now.

ivb-supercede avatar Sep 16 '22 10:09 ivb-supercede

Hmm, I tried using this branch.

Now this happens:

[3 of 5] Compiling Graphmod.CabalSupport ( src/Graphmod/CabalSupport.hs, dist/build/Graphmod/CabalSupport.o, dist/build/Graphmod/CabalSupport.dyn_o )

src/Graphmod/CabalSupport.hs:53:1: error:
    parse error on input ‘import’
   |
53 | import Distribution.Utils.Path (SymbolicPath, PackageDir, SourceDir, getSymbolicPath)

I guess it works on CI, because it's using an older cabal version.

jumper149 avatar Sep 16 '22 20:09 jumper149