Instant-Music-Downloader
Instant-Music-Downloader copied to clipboard
Reorder files and use standard setup.py config
Changes made :
- Move files from ./instantmusic-0.1 to ./instantmusic as its not a good way of doing versioning. Use git tag instead
- Delete install.sh and install.bat and super_installer.py as setup.py does all that and more. Only ceveat is
libav-tools
should be installed manually now on linux systems - Move instantmusic from bin folder to main folder
Effects:
Installation is standard and painless
[ To test it right now, use python setup.py build
from base folder and then use as usual. Should work ]
Todo :
- Build better/more packages for Pypi, including exe, wheel, egg, zip and all that. Its just one setup.py command away now.
- Proper testing on both platforms using travis and appveyor, to make sure that it keeps working on both platforms, even when the maintainers cant actively test on those systems. Travis setup right now doesnt do any testing, so write actual tests also,
@bendtherules This file was recently moved, before merging. Can you help me resolve these conflicts ?
Which file was recently moved ?
Are you talking about the last pull request for adding youtube-dl arg
?
I am talking about the current PR Reorder files and use standard setup.py config
which has conflicts.
Done, merged all the latest commits.
How come "requirements.txt" is not found? It is in that same folder.
For sanity, I have added the setup.py install
to travis and it installs all right, as seen on https://travis-ci.org/yask123/Instant-Music-Downloader/builds/85212004 (only one of the requirements fails to install on Py3.2)
Can you recheck your problem?
The requirements.txt
file didn't get uploaded.
Anyway, I hardcoded the required modules, here in version: 1.7 : https://pypi.python.org/pypi?:action=display&name=instantmusic&version=1.7
But the issue is, this does't work on Unix. I get this error Unrecognised command instantmusic
Are you trying to install it from my branch using python setup.py install
or something else?
your branch, you can see the source code here: https://pypi.python.org/pypi?:action=display&name=instantmusic&version=1.7
Can you please git pull from my fix_setup_windows branch
and python setup.py install
in that folder?
This version in PyPi is not my branch, its your old code.
I did that, still the same problem: Here is the log: http://pastebin.com/A80BwEPs
Can you run other scripts like, youtube-dl
from there where instantmusic
failed?
Both of them should be in /Library/Frameworks/Python.framework/Versions/2.7/bin
as seen in the log, which on the other hand, should be by default on your path. Check whether the scripts are actually there?
Its in the path, I guess it because of permission related issue.
The script is already there.
I can run it by $ python instantmusic
, but not by $ instantmusic
Does youtube-dl
work in the normal way?
Yes, it does.
Maybe we can get some help from @aviaryan ?
Yes, I dont have any Mac box. Let some other users try it out and see whether it works for them.
Look at the current travis logs with >py2.6 - Clearly, the instantmusic
command seems to work from any directory.
Fixing ID3 tags fails though in this case, but that is a separate issue.
Yes, thats right. I'll look into it when I get time.
instantmusic command works here (Py 3.4.2 x32 Win8.1x64). I didn't have any problems
@aviaryan I can't run it in Linux/Mac OSX.